This is an archive of the discontinued LLVM Phabricator instance.

[LLDB][MIPS] Fix TestDisassembleRawData.py
ClosedPublic

Authored by nitesh.jain on Jan 5 2016, 10:39 PM.

Download Raw Diff

Details

Reviewers

emaste
ovyalov
clayborg

Summary

This patch adds check for the correctness of Disassembling instruction for MIPS target.

Diff Detail

Repository: rL LLVM

Event Timeline

nitesh.jain updated this revision to Diff 44093.Jan 5 2016, 10:39 PM

nitesh.jain retitled this revision from to [LLDB][MIPS] Fix TestDisassembleRawData.py.

nitesh.jain updated this object.

nitesh.jain added reviewers: clayborg, • ovehakola, emaste.

nitesh.jain set the repository for this revision to rL LLVM.

nitesh.jain added subscribers: jaydeep, bhushan, slthakur and 2 others.

nitesh.jain edited reviewers, added: ovyalov; removed: • ovehakola.Jan 11 2016, 1:57 AM

clayborg accepted this revision.Jan 11 2016, 10:53 AM

clayborg edited edge metadata.

This revision is now accepted and ready to land.Jan 11 2016, 10:53 AM

ovyalov accepted this revision.Jan 11 2016, 11:34 AM

ovyalov edited edge metadata.

ovyalov added inline comments.

packages/Python/lldbsuite/test/python_api/disassemble-raw-data/TestDisassembleRawData.py
29	indentation
48	ditto

Committed in revision 257587 on behalf of Nitesh Jain.

Revision Contents

Path

Size

packages/

Python/

lldbsuite/

test/

python_api/

disassemble-raw-data/

TestDisassembleRawData.py

24 lines

Diff 44093

packages/Python/lldbsuite/test/python_api/disassemble-raw-data/TestDisassembleRawData.py

Context not available.
	def test_disassemble_raw_data(self):	def test_disassemble_raw_data(self):
	"""Test disassembling raw bytes with the API."""	"""Test disassembling raw bytes with the API."""
	# Create a target from the debugger.	# Create a target from the debugger.
	target = self.dbg.CreateTargetWithFileAndTargetTriple ("", "x86_64")	arch = self.getArchitecture()
		if re.match("mips*el",arch):
		target = self.dbg.CreateTargetWithFileAndTargetTriple ("", "mipsel")
		raw_bytes = bytearray([0x21,0xf0, 0xa0, 0x03])
		elif re.match("mips",arch):
		target = self.dbg.CreateTargetWithFileAndTargetTriple ("", "mips")
		ovyalovUnsubmitted Not Done Reply Inline Actions indentation ovyalov: indentation
		raw_bytes = bytearray([0x03,0xa0, 0xf0, 0x21])
		else:
		target = self.dbg.CreateTargetWithFileAndTargetTriple ("", "x86_64")
		raw_bytes = bytearray([0x48, 0x89, 0xe5])

	self.assertTrue(target, VALID_TARGET)	self.assertTrue(target, VALID_TARGET)

	raw_bytes = bytearray([0x48, 0x89, 0xe5])

	insts = target.GetInstructions(lldb.SBAddress(0, target), raw_bytes)	insts = target.GetInstructions(lldb.SBAddress(0, target), raw_bytes)

	inst = insts.GetInstructionAtIndex(0)	inst = insts.GetInstructionAtIndex(0)
Context not available.
	print()	print()
	print("Raw bytes: ", [hex(x) for x in raw_bytes])	print("Raw bytes: ", [hex(x) for x in raw_bytes])
	print("Disassembled%s" % str(inst))	print("Disassembled%s" % str(inst))
		if re.match("mips",arch):
	self.assertTrue (inst.GetMnemonic(target) == "movq")	self.assertTrue (inst.GetMnemonic(target) == "move")
	self.assertTrue (inst.GetOperands(target) == '%' + "rsp, " + '%' + "rbp")	self.assertTrue (inst.GetOperands(target) == '$' + "fp, " + '$' + "sp")
		else:
		self.assertTrue (inst.GetMnemonic(target) == "movq")
		ovyalovUnsubmitted Not Done Reply Inline Actions ditto ovyalov: ditto
		self.assertTrue (inst.GetOperands(target) == '%' + "rsp, " + '%' + "rbp")
Context not available.