Page MenuHomePhabricator

ovyalov (Oleksiy Vyalov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2014, 10:57 AM (246 w, 4 d)

Recent Activity

Aug 25 2016

ovyalov accepted D23877: Switch linux and android CODE_OWNERS.
Aug 25 2016, 9:47 AM

Aug 6 2016

ovyalov added a comment to rL277943: [RuntimeDyld] Replace manual flag checks with JITSymbolFlags::fromObjectSymbol..

It seems this CL broke lldb cmake build - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/17910/steps/ninja%20build%20local/logs/stdio, could you take a look?

Aug 6 2016, 5:53 PM

Aug 5 2016

ovyalov committed rL277895: Fix Windows build - add return statement in SBThread….
Fix Windows build - add return statement in SBThread…
Aug 5 2016, 5:50 PM
ovyalov added a comment to D23213: Allow SmallVector to be used as a yaml sequence.

Looks like this CL broke LLDB cmake buildbot - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/17873/steps/ninja%20build%20local/logs/stdio, could you take a look?

Aug 5 2016, 3:22 PM

Aug 2 2016

ovyalov added a comment to rL277561: [PM] Significantly refactor the pass pipeline parsing to be easier to.

It seems this CL is breaking lldb cmake build - could you take a look?

Aug 2 2016, 8:56 PM

Jul 21 2016

ovyalov committed rL276303: Add check for non-null log instance in PlatformAndroid..
Add check for non-null log instance in PlatformAndroid.
Jul 21 2016, 10:11 AM

Jul 12 2016

ovyalov committed rL275198: Add logging to Linux Host::GetProcessAndStatInfo..
Add logging to Linux Host::GetProcessAndStatInfo.
Jul 12 2016, 11:21 AM

Jul 8 2016

ovyalov closed D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file.

Files:

/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
Jul 8 2016, 10:53 AM
ovyalov committed rL274895: Use shell cat command as a workaround if ADB stat cannot lookup a file..
Use shell cat command as a workaround if ADB stat cannot lookup a file.
Jul 8 2016, 10:52 AM
ovyalov added a comment to D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file.

Thanks for adding the additional checks. Looks good apart from the clang-format changes. This looks like the llvm style. I am not sure how you've run this but it does not seem to have picked up LLDB's .clang-format file.

Are you using git? You need to set clangFormat.binary setting to a sufficient new version (ideally the one you've just built), so it knows how to handle our AlwaysBreakAfterReturnType: All format. Then git clang-format HEAD^ should just work (assuming you have git-clang-format in your path).

Jul 8 2016, 10:38 AM
ovyalov updated the diff for D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file.

Reran with proper clang-format.

Jul 8 2016, 10:35 AM

Jul 7 2016

ovyalov added a comment to D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file.

You raised good points here, Luke.

I've thought about the quoting issue, but as you have already noticed there is no way to pass arguments containing quotes to adb correctly. Thinking about it more, what we could do is detect this situation (look for ' in the file name) and abort the whole process even before issuing the "adb shell" command.

As for the return value, this should not be a big problem, as further down the line we will discover that this is not a real ELF file and ignore it, but perhaps we could help here by searching for the file name in the first 1K bytes of the result, and ignoring the file if we find it?

Oleksiy, what do you think?

Jul 7 2016, 6:47 PM
ovyalov updated the diff for D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file.

Addressed review comments:

  • Check whether shell command output starts with /system/bin/sh: in order to find out whether command failed
  • Fail-fast download if filename contains single-quotes
  • clang-format
Jul 7 2016, 6:39 PM
ovyalov accepted D22052: Respect `ANDROID_SERIAL` environment variable used by ADB.

LGTM

Jul 7 2016, 10:09 AM

Jul 6 2016

ovyalov retitled D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file from to Use shell cat command as a workaround if ADB stat cannot lookup a file.
Jul 6 2016, 7:01 PM
ovyalov added inline comments to D22052: Respect `ANDROID_SERIAL` environment variable used by ADB.
Jul 6 2016, 2:33 PM
ovyalov closed D22029: Fix ADB client disconnect issues.

Files:

/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.h
Jul 6 2016, 10:10 AM
ovyalov committed rL274638: Fix ADB client disconnect issues..
Fix ADB client disconnect issues.
Jul 6 2016, 10:09 AM
ovyalov accepted D22040: Add oat symbolization support for odex files.

LGTM

Jul 6 2016, 7:14 AM

Jul 5 2016

ovyalov committed rL274594: Fix Linux build..
Fix Linux build.
Jul 5 2016, 7:27 PM
ovyalov retitled D22029: Fix ADB client disconnect issues from to Fix ADB client disconnect issues.
Jul 5 2016, 7:00 PM

Jun 30 2016

ovyalov closed D21770: Improve ADB utilization within Android platform.

Files:

/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp
Jun 30 2016, 11:18 AM
ovyalov committed rL274256: Improve ADB utilization within Android platform..
Improve ADB utilization within Android platform.
Jun 30 2016, 11:17 AM
ovyalov added a comment to D21770: Improve ADB utilization within Android platform.

If you okay with that I'd like to submit this CL as-is and come up with unit test with a separate change list.

Jun 30 2016, 7:43 AM

Jun 29 2016

ovyalov added a comment to D21770: Improve ADB utilization within Android platform.

Is AdbClient getting big enough to deserve a couple of unit tests? All it would take is to add the ability to specify the address to connect to and make a small mock server that listens at that address?

Jun 29 2016, 7:48 AM

Jun 27 2016

ovyalov retitled D21770: Improve ADB utilization within Android platform from to Improve ADB utilization within Android platform.
Jun 27 2016, 2:55 PM

Jun 24 2016

ovyalov accepted D21680: Fix the libc++ pretty printers for the android NDK.

LGTM

Jun 24 2016, 11:03 AM

May 27 2016

ovyalov added a comment to D16861: Pass socket scheme as part of debug server listen URL.

This change broke connection to debugserver on OS X - the constructed URL on debugserver does not take the tcp:// (URL-scheme) portion. This would manifest when 'lldb-server platform' was attempting to launch debugserver.

I'm going to be making a fix for the debugserver case. I'll make sure it doesn't break Linux.

May 27 2016, 10:04 AM

May 24 2016

ovyalov closed D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache .

Submitted as r270590

May 24 2016, 11:17 AM
ovyalov committed rL270590: Replace file system forbidden symbols in the hostname which passed to the….
Replace file system forbidden symbols in the hostname which passed to the…
May 24 2016, 11:16 AM
ovyalov accepted D20570: Add unit tests for ModuleCache.
May 24 2016, 10:34 AM
ovyalov added a comment to D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache .

At some point we should probably make a host layer call like:

const char *const char *Host::GetIllegalFilenameCharacters();" so that each host can determine the correct thing for the current host. Then FileSpec can be updated to use this function handle this with a method like "void FileSpec::NormalizePathForHost()". This will probably need to be done elsewhere.

May 24 2016, 10:01 AM
ovyalov added a comment to D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache .

According to https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396, characters with codes 1..31 (basically < ' '), are illegal as well. We might as well convert those, just in case.

Agree - done.

I've been sitting on a unit test for the module cache locally for a while now... I guess it's time to put that in, and then we can add a test for this as well.

Sounds good.

May 24 2016, 9:57 AM
ovyalov updated the diff for D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache .

Added the check for symbol in [1;31] range.

May 24 2016, 9:57 AM

May 23 2016

ovyalov updated the diff for D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache .

Added asterisk symbol

May 23 2016, 6:22 PM
ovyalov retitled D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache from to Replace file system forbidden symbols in the hostname which passed to the ModuleCache .
May 23 2016, 6:17 PM

May 16 2016

ovyalov added a comment to rL269546: Added support to the ASTImporter for C++ constructor initializers..

Thank you, Sean.

May 16 2016, 1:57 PM

May 15 2016

ovyalov added a comment to rL269546: Added support to the ASTImporter for C++ constructor initializers..

I reverted this CL with r269575 because of test failures on CMake and Android buildbots - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14699. Feel free to re-submit it once the test issue is resolved.

May 15 2016, 7:57 PM

May 14 2016

ovyalov committed rL269575: Revert r269546 "Added support to the ASTImporter for C++ constructor….
Revert r269546 "Added support to the ASTImporter for C++ constructor…
May 14 2016, 12:13 PM
ovyalov retitled D20269: Revert r269546 "Added support to the ASTImporter for C++ constructor initializers." from to Revert r269546 "Added support to the ASTImporter for C++ constructor initializers.".
May 14 2016, 9:30 AM

May 12 2016

ovyalov added a comment to D19124: [LLDB] Added support for PHI nodes to IR interpreter.

Looks like this CL broke CMake build bot - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14634, could you take a look?

May 12 2016, 1:49 PM

May 9 2016

ovyalov added a comment to D20038: Make CodeView TypeIterator generic so that it can iterate symbols too.

Looks like this CL broke CMake buildbot - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14464, could you take a look?

May 9 2016, 11:07 AM

May 4 2016

ovyalov accepted D19916: Fix EOF handling in AdbClient (take 2).

LGTM

May 4 2016, 8:43 AM

Apr 28 2016

ovyalov added a comment to D19533: Introduce Connection::ReadAll and fix AdbClient.

LGTM

Apr 28 2016, 10:47 AM
ovyalov accepted D19540: Add support for displaying Java array types on Andorid.

LGTM

Apr 28 2016, 10:14 AM

Apr 27 2016

ovyalov accepted D19638: Use llvm:Twine instead of std::to_string..

LGTM

Apr 27 2016, 5:02 PM

Apr 26 2016

ovyalov accepted D19557: Use absolute module path when possible if sent in svr4 packets.

LGTM

Apr 26 2016, 2:44 PM

Apr 16 2016

ovyalov committed rL266530: Fix cmake build after r266524..
Fix cmake build after r266524.
Apr 16 2016, 9:34 AM

Apr 14 2016

ovyalov committed rL266401: Rename out->std_out in AppleObjCRuntimeV2.cpp..
Rename out->std_out in AppleObjCRuntimeV2.cpp.
Apr 14 2016, 6:01 PM
ovyalov added a comment to rL266351: Sink DI metadata usage out of MachineInstr.h and MachineInstrBuilder.h.

we have bunch of new failures on LLDB cmake build bot with ToT - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13420
It's failing due clang issue - CalledProcessError: Command 'make ARCH=x86_64 CC="/lldb-buildbot/lldbSlave/buildWorkingDir/scripts/../build/bin/clang" ' returned non-zero exit status 2
Is it possible that it's caused by this your CL?

Apr 14 2016, 12:44 PM
ovyalov added a comment to D19092: Fix Android build after r266267.

Why is this necessary? stdout is a local variable defined in this scope. Why would the android g++ have problems with this?

Anyway, if you have to avoid using stdout as a name, maybe name it std_out as that better reflects its meaning.

Apr 14 2016, 10:56 AM

Apr 13 2016

ovyalov added a comment to D19092: Fix Android build after r266267.

Submitted as http://reviews.llvm.org/rL266274

Apr 13 2016, 7:08 PM
ovyalov committed rL266274: Fix Android build after r266267.
Fix Android build after r266267
Apr 13 2016, 7:08 PM
ovyalov retitled D19092: Fix Android build after r266267 from to Fix Android build after r266267.
Apr 13 2016, 6:58 PM

Apr 12 2016

ovyalov committed rL266164: Attempt to fix TestCPPBreakpointLocations on Linux/Android..
Attempt to fix TestCPPBreakpointLocations on Linux/Android.
Apr 12 2016, 9:26 PM
ovyalov added a comment to D18883: Add a pass to name anonymous/nameless function.

It seems this CL is breaking LLDB Windows builder - http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/5228, could you take a look?

Apr 12 2016, 4:32 PM
ovyalov added a comment to rL266139: Fixed being able to set breakpoints on destructors when we don't fully….

Hi Greg,

Apr 12 2016, 3:42 PM
ovyalov accepted D19035: Fix breakpoint_set_restart test for Windows.
Apr 12 2016, 3:32 PM
ovyalov added a comment to rL265650: Enable TestDebugBreak on x86_64 as well.

It seems this CL made TestDebugBreak to fail on x86_64 on darwin build bot - http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/9529. Do we need to revert it for now?

Apr 12 2016, 7:20 AM

Apr 11 2016

ovyalov added a comment to D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received.

FYI: According to git bisect, this patch seems to have introduced a new test failure on Windows.

Apr 11 2016, 3:22 PM

Apr 8 2016

ovyalov added a comment to rL265858: -thread-info in lldbmi does not conform to protocol. Should end with current….

it seems cmake build bot started to fail after this CL - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13203. Could you take a look?

Apr 8 2016, 11:12 PM
ovyalov committed rL265869: Fix TestBreakpointSetRestart failure on Android..
Fix TestBreakpointSetRestart failure on Android.
Apr 8 2016, 8:13 PM
ovyalov closed D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received.

Submitted as http://reviews.llvm.org/rL265843

Apr 8 2016, 1:50 PM
ovyalov committed rL265843: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received..
Reset continue_after_async only if neither SIGINIT nor SIGSTOP received.
Apr 8 2016, 1:50 PM
ovyalov added a comment to D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received.

Does this fix an existing test or is a new issue? If it's new (it sounds like it is, as I don't see any test failures), could you also add a test for this. It shouldn't be too difficult to write one... Would something like this:

dbg.SetAsync(true)
process.Continue()
lldbutil.expect_state_changes(self,dbg.GetListener(), [eStateRunning])
target.BreakpointCreateBySourceRegex("// some code which will not get executed by the inferior")
do_some_assertions_on_the_breakpoint()
while dbg.GetListener().WaitForEvent(2, event):
  if SBProcess.GetStateFromEvent(event) == eStateStopped and SBProcess.GetRestartedFromEvent(state):
    continue
  if SBProcess.GetStateFromEvent(event) == eStateRunning:
    continue
  self.fail("Setting a breakpoint generated an unexpected event: %s"%SBDebugger.StateAsCString(SBProcess.GetStateFromEvent(event)));

do the trick?

Apr 8 2016, 12:15 PM
ovyalov updated the diff for D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received.

Added new TestBreakpointSetRestart test to cover the addressed issue.

Apr 8 2016, 12:15 PM

Apr 7 2016

ovyalov retitled D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received from to Reset continue_after_async only if neither SIGINIT nor SIGSTOP received.
Apr 7 2016, 6:54 PM
ovyalov added inline comments to rL265086: Fixed an issue that could cause debugserver to return two stop reply packets….
Apr 7 2016, 11:41 AM
ovyalov accepted D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI.

lgtm

Apr 7 2016, 10:24 AM

Mar 19 2016

ovyalov added a comment to rL263859: Add a DiagnosticManager replace error streams in the expression parser..

looks like this CL broke Windows build bot - http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/4882.
Could you take a look?

Mar 19 2016, 12:03 AM

Feb 25 2016

ovyalov committed rL261974: Make TestPlatformProcessConnect to support abstract/domain sockets..
Make TestPlatformProcessConnect to support abstract/domain sockets.
Feb 25 2016, 8:06 PM
ovyalov accepted D17616: Add a set of new plugins to handle Java debugging.
Feb 25 2016, 4:34 PM
ovyalov accepted D17604: Add support for DW_OP_push_object_address in dwarf expressions.

LGTM

Feb 25 2016, 10:30 AM

Feb 22 2016

ovyalov accepted D17509: Work around a stepping bug in arm64 android M.
Feb 22 2016, 10:45 AM
ovyalov accepted D17510: [linux] Remove all traces of signalfd(2).

LGTM

Feb 22 2016, 9:55 AM

Feb 18 2016

ovyalov added a comment to D3976: -Wcomma, a new warning for questionable uses of the comma operator.

It seems this CL broke LLDB CMake build bot - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11554
Could you take a look?

Feb 18 2016, 4:31 PM

Feb 16 2016

ovyalov added a comment to D16597: Query the StringMap only once when creating MDString (NFC).

It seems this CL broke LLDB Windows buildbot - http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/4316
Could you take a look?

Feb 16 2016, 5:13 PM
ovyalov accepted D17295: Stack unwinding emulation: handle adjustment of FP.

LGTM

Feb 16 2016, 2:09 PM

Feb 12 2016

ovyalov accepted D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS.

LGTM

Feb 12 2016, 9:23 AM

Feb 11 2016

ovyalov added inline comments to D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS.
Feb 11 2016, 2:37 PM

Feb 3 2016

ovyalov closed D16861: Pass socket scheme as part of debug server listen URL.

Submitted as http://reviews.llvm.org/rL259714

Feb 3 2016, 2:07 PM
ovyalov committed rL259714: Pass socket scheme as part of debug server listen URL..
Pass socket scheme as part of debug server listen URL.
Feb 3 2016, 2:06 PM
ovyalov retitled D16861: Pass socket scheme as part of debug server listen URL from to Pass socket scheme as part of debug server listen URL.
Feb 3 2016, 10:55 AM

Jan 29 2016

ovyalov accepted D16720: Set correct ThreadStopInfo in case of trace event.

LGTM

Jan 29 2016, 4:58 PM

Jan 23 2016

ovyalov added a comment to rL258654: [SCCP] Remove duplicate code.

CL is failing on lldb cmake buildbot - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10660

Jan 23 2016, 10:58 PM

Jan 22 2016

ovyalov added inline comments to rL258586: More fixes related to counting threads on Windows..
Jan 22 2016, 4:46 PM

Jan 20 2016

ovyalov added a comment to D15983: [GlobalISel] Add the proper cmake plumbing..

It seems lldb xcode build started to fail after this CL - http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/8218

Jan 20 2016, 5:52 PM

Jan 19 2016

ovyalov closed D16244: Implementing the method Target::TargetEventData::Dump (Stream *s) so that its clients can easily dump it out for informational messages..

Submitted as http://reviews.llvm.org/rL258150

Jan 19 2016, 9:59 AM
ovyalov committed rL258150: Implementing the method Target::TargetEventData::Dump (Stream *s) so that its….
Implementing the method Target::TargetEventData::Dump (Stream *s) so that its…
Jan 19 2016, 9:58 AM

Jan 15 2016

ovyalov accepted D16244: Implementing the method Target::TargetEventData::Dump (Stream *s) so that its clients can easily dump it out for informational messages..

LGTM

Jan 15 2016, 6:17 PM

Jan 13 2016

ovyalov added a comment to D16107: Fix for Bug 25338.

If vdso bug pertains to ELF format then it looks reasonable to keep the fix within ObjectFileELF.
I experimented a while ago with making ObjectFileELF to read from arbitrary offsets - please see http://reviews.llvm.org/D16151 as reflection of this idea (patch is pretty old and cannot be applied as-is).
Please take a look into it and let us know whether such approach may solve vdso problem.

Jan 13 2016, 12:26 PM
ovyalov retitled D16151: Read process memory from ObjectFileELF from to Read process memory from ObjectFileELF.
Jan 13 2016, 12:20 PM
ovyalov accepted D16136: [LLDB][MIPS] Fix TestPrintStackTraces.py.
Jan 13 2016, 11:25 AM

Jan 12 2016

ovyalov added a comment to D16107: Fix for Bug 25338.

vdso issue is related to ELF format and I'm wondering whether we can keep the fix contained in ObjectFileELF - for example, if a section that we're trying to read is beyond the boundaries of memory buffer we can read its content from inferior's memory using ObjectFile::m_process_wp.

Jan 12 2016, 11:31 AM

Jan 11 2016

ovyalov accepted D15915: [LLDB][MIPS] Fix TestDisassembleRawData.py.
Jan 11 2016, 11:34 AM

Dec 15 2015

ovyalov accepted D15533: Make the aarch64 lldb-server capable of debugging arm32 applications.
Dec 15 2015, 2:10 PM

Dec 11 2015

ovyalov committed rL255419: Remove unused mips typedefs..
Remove unused mips typedefs.
Dec 11 2015, 6:16 PM

Dec 10 2015

ovyalov accepted D15415: Add modules downloaded by ModuleCache to the global ModuleList.

LGTM

Dec 10 2015, 9:06 AM

Dec 9 2015

ovyalov accepted D15379: Switch to gold linker on android x86, x86_64, arm.

LGTM

Dec 9 2015, 10:30 AM

Dec 3 2015

ovyalov closed D15172: Fix in-memory section loading for JIT-ed code..

Submitted as http://reviews.llvm.org/rL254638

Dec 3 2015, 11:45 AM