This is an archive of the discontinued LLVM Phabricator instance.

Differential D159063

[openacc] Add declare op to data construct operations list
ClosedPublic

Authored by razvanlupusoru on Aug 28 2023, 10:02 PM.

Download Raw Diff

Details

Reviewers

vzakhari
clementval
nicolasvasilache

Commits

rG8cf814e6bd70: [openacc] Add declare op to data construct operations list

Summary

The macro ACC_DATA_CONSTRUCT_OPS defines all operations which are
data constructs. The recently DeclareOp was not added to the list.
Add it now.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

razvanlupusoru created this revision.Aug 28 2023, 10:02 PM

Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2023, 10:02 PM

Herald added subscribers: bviyer, Moerafaat, zero9178 and 21 others. · View Herald Transcript

razvanlupusoru requested review of this revision.Aug 28 2023, 10:02 PM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptAug 28 2023, 10:02 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

LGTM

This revision is now accepted and ready to land.Aug 28 2023, 10:44 PM

Harbormaster completed remote builds in B255410: Diff 554175.Aug 28 2023, 10:49 PM

clementval accepted this revision.Aug 29 2023, 9:15 AM

Rebase

This revision was landed with ongoing or failed builds.Aug 29 2023, 12:47 PM

Closed by commit rG8cf814e6bd70: [openacc] Add declare op to data construct operations list (authored by razvanlupusoru). · Explain Why

This revision was automatically updated to reflect the committed changes.

razvanlupusoru added a commit: rG8cf814e6bd70: [openacc] Add declare op to data construct operations list.

Harbormaster completed remote builds in B255606: Diff 554459.Aug 29 2023, 4:40 PM

Revision Contents

Path

Size

mlir/

include/

mlir/

Dialect/

OpenACC/

2 lines

Diff 554175

mlir/include/mlir/Dialect/OpenACC/OpenACC.h

	Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines		mlir::acc::CopyinOp, mlir::acc::CreateOp, mlir::acc::PresentOp, \
	mlir::acc::FirstprivateOp, mlir::acc::UpdateDeviceOp, \			mlir::acc::FirstprivateOp, mlir::acc::UpdateDeviceOp, \
	mlir::acc::UseDeviceOp, mlir::acc::ReductionOp, \			mlir::acc::UseDeviceOp, mlir::acc::ReductionOp, \
	mlir::acc::DeclareDeviceResidentOp, mlir::acc::DeclareLinkOp			mlir::acc::DeclareDeviceResidentOp, mlir::acc::DeclareLinkOp
	#define ACC_COMPUTE_CONSTRUCT_OPS \			#define ACC_COMPUTE_CONSTRUCT_OPS \
	mlir::acc::ParallelOp, mlir::acc::KernelsOp, mlir::acc::SerialOp			mlir::acc::ParallelOp, mlir::acc::KernelsOp, mlir::acc::SerialOp
	#define ACC_DATA_CONSTRUCT_OPS \			#define ACC_DATA_CONSTRUCT_OPS \
	mlir::acc::DataOp, mlir::acc::EnterDataOp, mlir::acc::ExitDataOp, \			mlir::acc::DataOp, mlir::acc::EnterDataOp, mlir::acc::ExitDataOp, \
	mlir::acc::UpdateOp, mlir::acc::HostDataOp, mlir::acc::DeclareEnterOp, \			mlir::acc::UpdateOp, mlir::acc::HostDataOp, mlir::acc::DeclareEnterOp, \
	mlir::acc::DeclareExitOp			mlir::acc::DeclareExitOp, mlir::acc::DeclareOp
	#define ACC_COMPUTE_AND_DATA_CONSTRUCT_OPS \			#define ACC_COMPUTE_AND_DATA_CONSTRUCT_OPS \
	ACC_COMPUTE_CONSTRUCT_OPS, ACC_DATA_CONSTRUCT_OPS			ACC_COMPUTE_CONSTRUCT_OPS, ACC_DATA_CONSTRUCT_OPS

	namespace mlir {			namespace mlir {
	namespace acc {			namespace acc {

	/// Enumeration used to encode the execution mapping on a loop construct.			/// Enumeration used to encode the execution mapping on a loop construct.
	/// They refer directly to the OpenACC 3.3 standard:			/// They refer directly to the OpenACC 3.3 standard:
	Show All 35 Lines