This is an archive of the discontinued LLVM Phabricator instance.

[clang-format][NFC] Change EXPECT_EQ to verifyFormat or verifyNoChang
ClosedPublic

Authored by owenpan on Aug 28 2023, 7:42 PM.

Details

Summary

Replaces some 600 EXPECT_EQ() to verifyFormat() or verifyNoChange() in FormatTest.cpp because the former neither checks stability of formatting nor tests formatting C++ as Objective C.

Also marks dozens of unstable test cases with FIXME comments.

Diff Detail

Event Timeline

owenpan created this revision.Aug 28 2023, 7:42 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptAug 28 2023, 7:42 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
owenpan requested review of this revision.Aug 28 2023, 7:42 PM
owenpan added inline comments.Aug 29 2023, 11:48 AM
clang/unittests/Format/FormatTest.cpp
23940

To be consistent with the surrounding test cases. (Will fix it before landing.)

This revision is now accepted and ready to land.Aug 29 2023, 12:26 PM
MyDeveloperDay accepted this revision.Aug 30 2023, 4:27 AM

+1 to this before we goto github

rG14feca5d14f1 concludes the cleanup of this gigantic file WRT EXPECT_EQ.