[clang-tidy] Disambiguate calls to log

[ro]

Summary

c8644b18f570be9d26d83cdeeb2369cd3cbddaf1 broke the Solaris/amd64 and Solaris/sparcv9 buildbots:

FAILED: tools/clang/tools/extra/clang-tidy/altera/CMakeFiles/obj.clangTidyAlteraModule.dir/UnrollLoopsCheck.cpp.o
[...]
/vol/llvm/src/llvm-project/dist/clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:217:25: error: call to 'log' is ambiguous 
  217 |       Iterations = 1 + (log(EndValue) - log(InitValue)) / log(ConstantValue);
      |                         ^~~
/usr/include/iso/math_iso.h:60:15: note: candidate function
   60 | extern double log __P((double));
      |               ^
/usr/include/iso/math_iso.h:158:15: note: candidate function
  158 |         inline float log(float __X) { return __logf(__X); }
      |                      ^
/usr/include/iso/math_iso.h:193:21: note: candidate function
  193 |         inline long double log(long double __X) { return __logl(__X); }
      |                            ^

Fixed by disambituating the calls with double casts.

Tested on amd64-pc-solaris2.11 and x86_64-pc-linux-gnu.

Will commit shortly to unbreak the bots.

[PiotrZSL]

Thank you.

clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp

if (const auto *Op = dyn_cast<BinaryOperator>(Increment)) {
     switch (Op->getOpcode()) {
     case (BO_AddAssign):
       Iterations = ceil(float(EndValue - InitValue) / ConstantValue);
       break;
     case (BO_SubAssign):
       Iterations = ceil(float(InitValue - EndValue) / ConstantValue);
       break;
     case (BO_MulAssign):
-      Iterations = 1 + (log(EndValue) - log(InitValue)) / log(ConstantValue);
+      Iterations = 1 + (log((double)EndValue) - log((double)InitValue)) /
+                           log((double)ConstantValue);
       break;
     case (BO_DivAssign):
-      Iterations = 1 + (log(InitValue) - log(EndValue)) / log(ConstantValue);
+      Iterations = 1 + (log((double)InitValue) - log((double)EndValue)) /
+                           log((double)ConstantValue);
       break;
     default:
       // All other operators are not handled; assume large bounds.
       return true;
     }
   }
   return Iterations > MaxLoopIterations;
 }