This is an archive of the discontinued LLVM Phabricator instance.

Differential D158937

[Test] Check that the outlined functions have internal visibility
ClosedPublic

Authored by hiraditya on Aug 26 2023, 9:37 AM.

Details

Reviewers
vsk
eli.friedman
yassingh
Commits
rG5897b449472e: [HotColdSplit Test] Check that the outlined functions have internal visibility
Summary

NFC

Diff Detail

Event Timeline

hiraditya created this revision.Aug 26 2023, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2023, 9:37 AM
hiraditya requested review of this revision.Aug 26 2023, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2023, 9:37 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B255092: Diff 553741.Aug 26 2023, 10:08 AM
yassingh added a reviewer: yassingh.Aug 26 2023, 10:27 AM
yassingh accepted this revision.Aug 26 2023, 10:33 AM

It looks alright, just adding more details in the checks. Is there a specific reason you are updating these 2 in particular?

This revision is now accepted and ready to land.Aug 26 2023, 10:33 AM
hiraditya added a comment.Aug 26 2023, 11:40 AM
In D158937#4619667, @yassingh wrote:

It looks alright, just adding more details in the checks. Is there a specific reason you are updating these 2 in particular?

not specific to these tests but i want internal visibility to be tested.

Closed by commit rG5897b449472e: [HotColdSplit Test] Check that the outlined functions have internal visibility (authored by AdityaK <1894981+hiraditya@users.noreply.github.com>). · Explain WhyAug 27 2023, 6:49 AM
This revision was automatically updated to reflect the committed changes.
AdityaK <1894981+hiraditya@users.noreply.github.com> added a commit: rG5897b449472e: [HotColdSplit Test] Check that the outlined functions have internal visibility.

Revision Contents

PathSize
llvm/
test/
Transforms/
HotColdSplit/
2 lines
2 lines

Diff 553741

llvm/test/Transforms/HotColdSplit/region-overlap.ll

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines; <label>:11: ; preds = %10, %7
call void @_Z10sideeffecti(i32 1) call void @_Z10sideeffecti(i32 1)
call void @_Z4sinki(i32 1) #3 call void @_Z4sinki(i32 1) #3
br label %12 br label %12
; <label>:12: ; preds = %11, %2 ; <label>:12: ; preds = %11, %2
ret void ret void
} }
; CHECK-LABEL: define {{.*}}@_Z3fooii.cold.1 ; CHECK-LABEL: define internal {{.*}}@_Z3fooii.cold.1
; CHECK: call void @_Z10sideeffecti(i32 0) ; CHECK: call void @_Z10sideeffecti(i32 0)
declare void @_Z10sideeffecti(i32) declare void @_Z10sideeffecti(i32)
declare void @_Z4sinki(i32) cold declare void @_Z4sinki(i32) cold

llvm/test/Transforms/HotColdSplit/split-cold-2.ll

; RUN: opt -passes=hotcoldsplit -hotcoldsplit-threshold=-1 -pass-remarks=hotcoldsplit -S < %s 2>&1 | FileCheck %s ; RUN: opt -passes=hotcoldsplit -hotcoldsplit-threshold=-1 -pass-remarks=hotcoldsplit -S < %s 2>&1 | FileCheck %s
; Make sure this compiles. This test used to fail with an invalid phi node: the ; Make sure this compiles. This test used to fail with an invalid phi node: the
; two predecessors were outlined and the SSA representation was invalid. ; two predecessors were outlined and the SSA representation was invalid.
; CHECK: remark: <unknown>:0:0: fun split cold code into fun.cold.1 ; CHECK: remark: <unknown>:0:0: fun split cold code into fun.cold.1
; CHECK-LABEL: @fun ; CHECK-LABEL: @fun
; CHECK: codeRepl: ; CHECK: codeRepl:
; CHECK-NEXT: call void @fun.cold.1 ; CHECK-NEXT: call void @fun.cold.1
; CHECK: define {{.*}}@fun.cold.1{{.*}} [[cold_attr:#[0-9]+]] ; CHECK: define internal {{.*}}@fun.cold.1{{.*}} [[cold_attr:#[0-9]+]]
; CHECK: attributes [[cold_attr]] = { {{.*}}noreturn ; CHECK: attributes [[cold_attr]] = { {{.*}}noreturn
define void @fun() { define void @fun() {
entry: entry:
br i1 undef, label %if.then, label %if.else br i1 undef, label %if.then, label %if.else
if.then: if.then:
ret void ret void
Show All 17 Lines