[Test] Check that the outlined functions have internal visibility

[hiraditya]

Summary

NFC

[yassingh]

It looks alright, just adding more details in the checks. Is there a specific reason you are updating these 2 in particular?

[hiraditya]

In D158937#4619667, @yassingh wrote:

It looks alright, just adding more details in the checks. Is there a specific reason you are updating these 2 in particular?

not specific to these tests but i want internal visibility to be tested.

llvm/test/Transforms/HotColdSplit/region-overlap.ll

; <label>:11:                                     ; preds = %10, %7
   call void @_Z10sideeffecti(i32 1)
   call void @_Z4sinki(i32 1) #3
   br label %12
 
 ; <label>:12:                                     ; preds = %11, %2
   ret void
 }
 
-; CHECK-LABEL: define {{.*}}@_Z3fooii.cold.1
+; CHECK-LABEL: define internal {{.*}}@_Z3fooii.cold.1
 ; CHECK: call void @_Z10sideeffecti(i32 0)
 
 declare void @_Z10sideeffecti(i32)
 
 declare void @_Z4sinki(i32) cold

llvm/test/Transforms/HotColdSplit/split-cold-2.ll

 ; RUN: opt -passes=hotcoldsplit -hotcoldsplit-threshold=-1 -pass-remarks=hotcoldsplit -S < %s 2>&1 | FileCheck %s
 
 ; Make sure this compiles. This test used to fail with an invalid phi node: the
 ; two predecessors were outlined and the SSA representation was invalid.
 
 ; CHECK: remark: <unknown>:0:0: fun split cold code into fun.cold.1
 ; CHECK-LABEL: @fun
 ; CHECK: codeRepl:
 ; CHECK-NEXT: call void @fun.cold.1
 
-; CHECK: define {{.*}}@fun.cold.1{{.*}} [[cold_attr:#[0-9]+]]
+; CHECK: define internal {{.*}}@fun.cold.1{{.*}} [[cold_attr:#[0-9]+]]
 ; CHECK: attributes [[cold_attr]] = { {{.*}}noreturn
 
 define void @fun() {
 entry:
   br i1 undef, label %if.then, label %if.else
 
 if.then:
   ret void