Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/lib/Analysis/ThreadSafety.cpp | ||
---|---|---|
2243 | It seems to me that CurrentMethod is unconditionally assigned a value here, before it is being read anywhere. |
Comment Actions
LGTM though I can take or leave the changes to ThreadSafety.cpp.
clang/lib/Analysis/ThreadSafety.cpp | ||
---|---|---|
2243 | It is, but this isn't the ThreadSafetyAnalyzer constructor, so there's a window for misuse. So I think this is a false positive, but still a reasonable enough change to make. |
It seems to me that CurrentMethod is unconditionally assigned a value here, before it is being read anywhere.