This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Cleanup last vestiges of Minix / Contiki support
ClosedPublic

Authored by brad on Aug 24 2023, 1:04 AM.

Details

Reviewers
MaskRay
Summary

Cleanup what is left after https://reviews.llvm.org/D158461

Diff Detail

Event Timeline

brad created this revision.Aug 24 2023, 1:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2023, 1:04 AM
brad requested review of this revision.Aug 24 2023, 1:04 AM
MaskRay accepted this revision.Aug 24 2023, 2:01 PM
This revision is now accepted and ready to land.Aug 24 2023, 2:01 PM
brad closed this revision.Aug 25 2023, 4:18 PM

Oops. I missed pasting the URL when commiting this.

uabelho added a subscriber: uabelho.Sep 6 2023, 2:12 AM
uabelho added inline comments.
clang/lib/Lex/InitHeaderSearch.cpp
336

@brad :
I think this was the last use of the AddGnuCPlusPlusIncludePaths method, should we remove it now or is it likely it will be used again?

brad added inline comments.Sep 6 2023, 4:20 PM
clang/lib/Lex/InitHeaderSearch.cpp
336

@brad :
I think this was the last use of the AddGnuCPlusPlusIncludePaths method, should we remove it now or is it likely it will be used again?

I noticed a function of the same name with the Darwin Driver.

uabelho added inline comments.Sep 6 2023, 9:51 PM
clang/lib/Lex/InitHeaderSearch.cpp
336

Yeah Darwin defines and uses its own function with that name, but the one in InitHeaderSearch is unused since this patch.

I don't know anything about this, just noticed that gcc warns about it being unused.