This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Container-size-empty fixed c++ version in tests to support string_literals operator
ClosedPublic

Authored by felix642 on Aug 23 2023, 6:46 PM.

Details

Summary

The goal of this PR is to properly implement the std::string_literals::operator""s that was added in commit (4001ae175cbe) but was later changed in commit (ba52a10fca6fc7b791894c584233db012def68a5).

The operator""s was added in c++14 but we were running tests under c++11 which would raise an error when compiling the file.

Diff Detail

Event Timeline

felix642 created this revision.Aug 23 2023, 6:46 PM
felix642 requested review of this revision.Aug 23 2023, 6:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 6:46 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
felix642 edited the summary of this revision. (Show Details)Aug 23 2023, 6:51 PM
This revision is now accepted and ready to land.Aug 25 2023, 12:24 AM