- User Since
- Sep 2 2022, 7:44 PM (65 w, 6 d)
Oct 2 2023
Wrong check name
Sep 18 2023
Sep 8 2023
Forgot to update a comment
Moved to a new method, changed tests, changed documentation
Removed false option
Updated Differential to truly support optional parameters
Sep 4 2023
Reworded release notes
Added entry to release notes
Aug 31 2023
In that case, I agree with you, it would be helpful to add this feature. I think supporting an empty value rather than a boolean is preferable. We should maybe do that in another Differential though. I can open an issue on github and I'll open another diff when I'm ready. What do you think?
We can already disable those options if we don't define them in the config. Adding the possibility to provide optional values seems redundant to me. Do you see any reason why we would absolutely need to add this option to the config if we want to disable it?
Aug 28 2023
Fixed commit message
Aug 23 2023
Aug 19 2023
Hi @PiotrZSL, thank you for the feedback.
Fixed tests and addressed comments.
Hi @PiotrZSL thank you for taking the time to look at this revision.
Aug 15 2023
HI @PiotrZSL, I do not have the rights to commit to the LLVM repository. Could you please commit those changes for me?
Aug 14 2023
Updated commit message
Aug 13 2023
Jun 18 2023
Jun 14 2023
Renamed allowedIdentifiers to allowedIdentifiersRaw
Moved regex parsing to a new method
Moved entry in releaseNotes.rst
Jun 12 2023
Jun 11 2023
I have made the requested changes. If everything looks good to you would you mind committing this patch for me as I don't have commit access to the repository. Thank you.
Jun 7 2023
Removed duplicated messages in tests.
Added support for regular expressions
Added method to store options.
Jun 5 2023
Oct 21 2022
Updated documentation and code review
Oct 20 2022
Oct 2 2022
Sep 24 2022
Sep 15 2022
Sep 8 2022
Changed tests to check with and without config.
Sep 5 2022
Improved readability of release note.
Sep 3 2022
Fixed compilation issues
+ Added test case and updated ReleaseNotes