Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

People felix642

felix642 (Félix-Antoine Constantin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 2 2022, 7:44 PM (65 w, 6 d)

Recent Activity
View All

Oct 2 2023

felix642 updated the diff for D159436: [clang-tidy] Add support for optional parameters in config..

Wrong check name

Oct 2 2023, 7:03 PM · Restricted Project, Restricted Project
felix642 updated the diff for D159436: [clang-tidy] Add support for optional parameters in config..

Updated documentation

Oct 2 2023, 7:02 PM · Restricted Project, Restricted Project

Sep 18 2023

felix642 abandoned D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals..
Sep 18 2023, 3:20 PM · Restricted Project, Restricted Project
felix642 added a comment to D159436: [clang-tidy] Add support for optional parameters in config..

ping.

Sep 18 2023, 3:19 PM · Restricted Project, Restricted Project

Sep 8 2023

felix642 updated the diff for D159436: [clang-tidy] Add support for optional parameters in config..

Forgot to update a comment

Sep 8 2023, 8:12 PM · Restricted Project, Restricted Project
felix642 added a comment to D159436: [clang-tidy] Add support for optional parameters in config..

Hi @PiotrZSL and @carlosgalvezp, I have updated my diff based on your comments. Let me know what you think.

What if:
Sep 8 2023, 8:11 PM · Restricted Project, Restricted Project
felix642 updated the diff for D159436: [clang-tidy] Add support for optional parameters in config..

Moved to a new method, changed tests, changed documentation

Sep 8 2023, 8:07 PM · Restricted Project, Restricted Project
felix642 updated the diff for D159436: [clang-tidy] Add support for optional parameters in config..

Removed false option

Sep 8 2023, 7:01 PM · Restricted Project, Restricted Project
felix642 updated the diff for D159436: [clang-tidy] Add support for optional parameters in config..

Updated documentation

Sep 8 2023, 5:25 PM · Restricted Project, Restricted Project
felix642 updated the diff for D159436: [clang-tidy] Add support for optional parameters in config..

Updated Differential to truly support optional parameters

Sep 8 2023, 5:18 PM · Restricted Project, Restricted Project

Sep 4 2023

felix642 updated the diff for D159436: [clang-tidy] Add support for optional parameters in config..

Reworded release notes

Sep 4 2023, 7:15 PM · Restricted Project, Restricted Project
felix642 updated the diff for D159436: [clang-tidy] Add support for optional parameters in config..

Added entry to release notes

Sep 4 2023, 7:14 PM · Restricted Project, Restricted Project
felix642 added a reviewer for D159436: [clang-tidy] Add support for optional parameters in config.: PiotrZSL.
Sep 4 2023, 7:02 PM · Restricted Project, Restricted Project
felix642 requested review of D159436: [clang-tidy] Add support for optional parameters in config..
Sep 4 2023, 7:01 PM · Restricted Project, Restricted Project

Aug 31 2023

felix642 added a comment to D159045: [clang-tidy] Improved documentation for readability-function-size.

In that case, I agree with you, it would be helpful to add this feature. I think supporting an empty value rather than a boolean is preferable. We should maybe do that in another Differential though. I can open an issue on github and I'll open another diff when I'm ready. What do you think?

Aug 31 2023, 9:53 AM · Restricted Project, Restricted Project
felix642 added a comment to D159045: [clang-tidy] Improved documentation for readability-function-size.

We can already disable those options if we don't define them in the config. Adding the possibility to provide optional values seems redundant to me. Do you see any reason why we would absolutely need to add this option to the config if we want to disable it?

Aug 31 2023, 9:01 AM · Restricted Project, Restricted Project

Aug 28 2023

felix642 added a reviewer for D159045: [clang-tidy] Improved documentation for readability-function-size: PiotrZSL.
Aug 28 2023, 5:37 PM · Restricted Project, Restricted Project
felix642 updated the diff for D159045: [clang-tidy] Improved documentation for readability-function-size.

Linked issue

Aug 28 2023, 5:37 PM · Restricted Project, Restricted Project
felix642 updated the diff for D159045: [clang-tidy] Improved documentation for readability-function-size.

Fixed commit message

Aug 28 2023, 5:36 PM · Restricted Project, Restricted Project
felix642 requested review of D159045: [clang-tidy] Improved documentation for readability-function-size.
Aug 28 2023, 5:36 PM · Restricted Project, Restricted Project

Aug 23 2023

felix642 updated the summary of D158691: [clang-tidy] Container-size-empty fixed c++ version in tests to support string_literals operator.
Aug 23 2023, 6:51 PM · Restricted Project, Restricted Project
felix642 added reviewers for D158691: [clang-tidy] Container-size-empty fixed c++ version in tests to support string_literals operator: rnk, PiotrZSL.
Aug 23 2023, 6:47 PM · Restricted Project, Restricted Project
felix642 requested review of D158691: [clang-tidy] Container-size-empty fixed c++ version in tests to support string_literals operator.
Aug 23 2023, 6:46 PM · Restricted Project, Restricted Project

Aug 19 2023

felix642 updated the diff for D158346: [clang-tidy] readability-container-size-empty - detect missing usage of .empty() on string_literals .

Clang-format

Aug 19 2023, 2:34 PM · Restricted Project, Restricted Project
felix642 added a comment to D158346: [clang-tidy] readability-container-size-empty - detect missing usage of .empty() on string_literals .

Hi @PiotrZSL, thank you for the feedback.

Aug 19 2023, 1:33 PM · Restricted Project, Restricted Project
felix642 updated the diff for D158346: [clang-tidy] readability-container-size-empty - detect missing usage of .empty() on string_literals .

Fixed tests and addressed comments.

Aug 19 2023, 1:31 PM · Restricted Project, Restricted Project
felix642 added a comment to D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals..

Hi @PiotrZSL thank you for taking the time to look at this revision.

Aug 19 2023, 12:46 PM · Restricted Project, Restricted Project
PiotrZSL awarded D158346: [clang-tidy] readability-container-size-empty - detect missing usage of .empty() on string_literals a Like token.
Aug 19 2023, 12:31 PM · Restricted Project, Restricted Project
felix642 requested review of D158346: [clang-tidy] readability-container-size-empty - detect missing usage of .empty() on string_literals .
Aug 19 2023, 12:13 PM · Restricted Project, Restricted Project
felix642 added a reviewer for D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals.: aaron.ballman.
Aug 19 2023, 10:20 AM · Restricted Project, Restricted Project
felix642 added a reviewer for D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals.: lebedev.ri.
Aug 19 2023, 10:18 AM · Restricted Project, Restricted Project
felix642 updated the diff for D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals..

Fixed format

Aug 19 2023, 10:12 AM · Restricted Project, Restricted Project
felix642 requested review of D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals..
Aug 19 2023, 10:10 AM · Restricted Project, Restricted Project

Aug 15 2023

felix642 added a comment to D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion.

HI @PiotrZSL, I do not have the rights to commit to the LLVM repository. Could you please commit those changes for me?

Aug 15 2023, 5:35 PM · Restricted Project, Restricted Project
felix642 updated the diff for D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion.

Updated format

Aug 15 2023, 5:33 PM · Restricted Project, Restricted Project

Aug 14 2023

felix642 updated the diff for D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion.

Updated commit message

Aug 14 2023, 6:05 PM · Restricted Project, Restricted Project
felix642 updated the diff for D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion.

Code review

Aug 14 2023, 5:41 PM · Restricted Project, Restricted Project

Aug 13 2023

felix642 added a reviewer for D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion: carlosgalvezp.
Aug 13 2023, 7:40 PM · Restricted Project, Restricted Project
felix642 requested review of D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion.
Aug 13 2023, 7:37 PM · Restricted Project, Restricted Project

Jun 18 2023

felix642 updated the diff for D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions.

Resolved comments.

Jun 18 2023, 6:10 PM · Restricted Project, Restricted Project

Jun 14 2023

felix642 updated the diff for D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions.

Renamed allowedIdentifiers to allowedIdentifiersRaw
Moved regex parsing to a new method
Moved entry in releaseNotes.rst

Jun 14 2023, 6:20 PM · Restricted Project, Restricted Project

Jun 12 2023

felix642 added a reviewer for D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions: logan-5.
Jun 12 2023, 6:02 PM · Restricted Project, Restricted Project
felix642 requested review of D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions.
Jun 12 2023, 5:58 PM · Restricted Project, Restricted Project

Jun 11 2023

felix642 added a comment to D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Hi @PiotrZSL,
I have made the requested changes. If everything looks good to you would you mind committing this patch for me as I don't have commit access to the repository. Thank you.

Jun 11 2023, 7:44 PM · Restricted Project, Restricted Project
felix642 updated the diff for D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Updated documentation

Jun 11 2023, 7:38 PM · Restricted Project, Restricted Project

Jun 7 2023

felix642 updated the diff for D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Improved documentation
Removed duplicated messages in tests.
Added support for regular expressions
Added method to store options.

Jun 7 2023, 6:58 PM · Restricted Project, Restricted Project

Jun 5 2023

felix642 added a comment to D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

ping?

Jun 5 2023, 2:16 PM · Restricted Project, Restricted Project

Oct 21 2022

felix642 updated the diff for D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Updated ReleaseNotes.rst

Oct 21 2022, 5:27 PM · Restricted Project, Restricted Project
felix642 updated the diff for D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Updated documentation and code review

Oct 21 2022, 5:25 PM · Restricted Project, Restricted Project
felix642 added inline comments to D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.
Oct 21 2022, 5:12 PM · Restricted Project, Restricted Project

Oct 20 2022

felix642 added a comment to D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Ping.

Oct 20 2022, 5:33 PM · Restricted Project, Restricted Project
felix642 added a reviewer for D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers: fwolff.
Oct 20 2022, 5:33 PM · Restricted Project, Restricted Project

Oct 2 2022

felix642 added a comment to D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Ping.

Oct 2 2022, 5:00 PM · Restricted Project, Restricted Project

Sep 24 2022

felix642 added a comment to D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Ping.

Sep 24 2022, 7:17 PM · Restricted Project, Restricted Project

Sep 15 2022

felix642 added a comment to D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Ping.

Sep 15 2022, 7:06 PM · Restricted Project, Restricted Project

Sep 8 2022

felix642 added inline comments to D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.
Sep 8 2022, 7:03 PM · Restricted Project, Restricted Project
felix642 updated the diff for D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Changed tests to check with and without config.

Sep 8 2022, 6:59 PM · Restricted Project, Restricted Project

Sep 5 2022

felix642 updated the diff for D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Improved readability of release note.

Sep 5 2022, 6:10 PM · Restricted Project, Restricted Project
felix642 added inline comments to D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.
Sep 5 2022, 6:09 PM · Restricted Project, Restricted Project

Sep 3 2022

felix642 updated the diff for D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

Fixed compilation issues

Sep 3 2022, 9:00 PM · Restricted Project, Restricted Project
felix642 updated the diff for D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.

+ Added test case and updated ReleaseNotes

Sep 3 2022, 8:55 PM · Restricted Project, Restricted Project

Sep 2 2022

felix642 updated the summary of D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.
Sep 2 2022, 8:00 PM · Restricted Project, Restricted Project
felix642 requested review of D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers.
Sep 2 2022, 7:52 PM · Restricted Project, Restricted Project