This is an archive of the discontinued LLVM Phabricator instance.

Bitset: remove some GCC<6.2 workarounds related to bitwise operators
ClosedPublic

Authored by MaskRay on Aug 23 2023, 5:33 PM.

Details

Summary

GCC<6.2 has been unsupported since April 2022 (commit 4c72deb613d9d8838785b431facb3eb480fb2f51).

X86TargetParser.cpp has another workaround that the other 2 nearly identical places don't have. Remove them as well.

Diff Detail

Event Timeline

MaskRay created this revision.Aug 23 2023, 5:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 5:33 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
MaskRay requested review of this revision.Aug 23 2023, 5:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 5:33 PM
arsenm accepted this revision.Aug 23 2023, 6:11 PM
This revision is now accepted and ready to land.Aug 23 2023, 6:11 PM
MaskRay edited the summary of this revision. (Show Details)Aug 23 2023, 6:18 PM
MaskRay updated this revision to Diff 552944.Aug 23 2023, 6:39 PM

Fix type: the 3 copies are not identical :(

This revision was landed with ongoing or failed builds.Aug 23 2023, 6:44 PM
This revision was automatically updated to reflect the committed changes.