This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen][DebugInfo] Add x86 entry value tests
ClosedPublic

Authored by fdeazeve on Aug 23 2023, 9:44 AM.

Details

Summary

We should also test the x86 target, since it has different backend defaults from
ARM.

Diff Detail

Event Timeline

fdeazeve created this revision.Aug 23 2023, 9:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 9:44 AM
fdeazeve requested review of this revision.Aug 23 2023, 9:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 9:44 AM
aprantl accepted this revision.Aug 23 2023, 11:31 AM
This revision is now accepted and ready to land.Aug 23 2023, 11:31 AM
This revision was automatically updated to reflect the committed changes.

Hi @fdeazeve,

the test gets failed on Aarch64 builders

please note, this builder supports only Arm/Aarch64 targets and it does not support x86_64 and any other targets.

Hi @fdeazeve,

the test gets failed on Aarch64 builders

please note, this builder supports only Arm/Aarch64 targets and it does not support x86_64 and any other targets.

Ohhh that explains a lot!
Thank you, I'll have a fix in a few minutes

Pushed a quick fix

Argh, I added one more test along the same lines, gotta fix that one too