Fixes an issue where isCastLikeExtractSliceOp did not account for the fact
that tensor.extract_slice may drop non-unit dimensions. This change makes the
utility function behave inline with its name/description. The only user of this
function is in the FindPayloadReplacementOpInterface for the
tensor::ExtractSliceOp. This can potentially cause downstream projects to have
more "listener could not find replacement op" errors when interpreting Transform
IR, but the behavior is inline with the documented conservative behavior of the
Transform dialect's TrackingListener.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/Tensor/Utils/Utils.cpp | ||
---|---|---|
96 | no need to change this here, but I just noticed that CastLike is not really the correct term. It should be CastOrReshapeLike (or something like that...) |
no need to change this here, but I just noticed that CastLike is not really the correct term. It should be CastOrReshapeLike (or something like that...)