Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D158637

[mlir][tensor] Add canonicalization of `tensor.extract` from cast-like slice
Needs ReviewPublic
Actions

Authored by christopherbate on Aug 23 2023, 10:09 AM.

Details

Reviewers
nicolasvasilache
Summary

Adds a canonicalization for tensor.extract. When an extract occurs on
a rank-reducing (of unit-dimensions) tensor.extract_slice operation,
the tensor.extract can act on the source of the tensor.extract_slice.

Depends on D158635

Diff Detail

Event Timeline

christopherbate created this revision.Aug 23 2023, 10:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 10:09 AM
Herald added subscribers: bviyer, hanchung, Moerafaat and 21 others. · View Herald Transcript
christopherbate requested review of this revision.Aug 23 2023, 10:09 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptAug 23 2023, 10:09 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B254389: Diff 552779.Aug 23 2023, 11:34 AM
nicolasvasilache added inline comments.Aug 30 2023, 5:11 AM
mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
861

While this pattern seems fine to me with this check, I think the other comments in https://reviews.llvm.org/D158643 could still apply?

Revision Contents
Changeset List

PathSize
mlir/
lib/
Dialect/
Tensor/
IR/
37 lines
test/
Dialect/
Tensor/
32 lines

Diff 552779

View Options

mlir/lib/Dialect/Tensor/IR/TensorOps.cpp

Loading...
View Options

mlir/test/Dialect/Tensor/canonicalize.mlir

Loading...