This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Disable trivially-destructible check for darwin
AbandonedPublic

Authored by hiraditya on Aug 22 2023, 11:47 AM.

Details

Summary

For fat binaries this test fails. https://github.com/llvm/llvm-project/issues/60304

The real fix would be to change the hack encoded in clang tidy that looks for compilation commands of other files in the same directory.

Diff Detail

Event Timeline

hiraditya created this revision.Aug 22 2023, 11:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2023, 11:47 AM
Herald added a subscriber: xazax.hun. · View Herald Transcript
hiraditya requested review of this revision.Aug 22 2023, 11:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2023, 11:47 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
hiraditya edited the summary of this revision. (Show Details)Aug 22 2023, 11:51 AM
hiraditya abandoned this revision.Aug 22 2023, 2:41 PM

626849c71e85d546a004cc91866beab610222194 didn't fix this issue already ?

ah you're right. that fixes it. i should have tested on lastest clang.