This is an archive of the discontinued LLVM Phabricator instance.

Differential D158446

[libcxx][NFC] Update status documentation for stride range view
ClosedPublic

Authored by hawkinsw on Aug 21 2023, 12:36 PM.

Details

Reviewers
ldionne
H-G-Hristov
var-const
Mordante
Group Reviewers
Restricted Project
Commits
rG3db0e400f0a9: [libcxx][NFC] Update status documentation for stride range view
Summary

Note that there is a Differential revision for the stride ranges
view implementation and the names of the people who are developing
it.

Diff Detail

Event Timeline

hawkinsw created this revision.Aug 21 2023, 12:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 12:36 PM
hawkinsw requested review of this revision.Aug 21 2023, 12:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 12:36 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
hawkinsw added a comment.Aug 21 2023, 12:37 PM

Hope that I followed proper protocol! Thanks, everyone!

Harbormaster completed remote builds in B253905: Diff 552103.Aug 21 2023, 2:13 PM
Zingam added a subscriber: Zingam.Aug 22 2023, 4:02 AM

I think you can push this without a review. Just make sure the syntax is correct.

hawkinsw added a comment.Aug 22 2023, 9:58 AM
In D158446#4606341, @Zingam wrote:

I think you can push this without a review. Just make sure the syntax is correct.

Thanks! I will look up how to do that, but I honestly don't think that I have the proper permissions yet for that.

Mordante accepted this revision.Aug 22 2023, 11:44 AM
Mordante added a subscriber: Mordante.
In D158446#4607287, @hawkinsw wrote:
In D158446#4606341, @Zingam wrote:

I think you can push this without a review. Just make sure the syntax is correct.

Thanks! I will look up how to do that, but I honestly don't think that I have the proper permissions yet for that.

At the moment you don't have permission. After contributing more patches you can get access.

For the future it's fine to have done this in D156924. Then you can directly change the In Progress to Completed. For now I'll land it on your behalf.

This revision is now accepted and ready to land.Aug 22 2023, 11:44 AM
Mordante added a comment.Aug 22 2023, 11:47 AM

Can you provide your user name and email address so I can land it on your behalf?

hawkinsw added a comment.Aug 22 2023, 1:01 PM
In D158446#4607682, @Mordante wrote:

Can you provide your user name and email address so I can land it on your behalf?

Thank you!!

hawkinsw
whh8b@obs.cr

Thank you!

Mordante added a comment.Aug 23 2023, 8:48 AM
In D158446#4607932, @hawkinsw wrote:
In D158446#4607682, @Mordante wrote:

Can you provide your user name and email address so I can land it on your behalf?

Thank you!!

hawkinsw
whh8b@obs.cr

Thank you!

In general we prefer real names. Are you fine with committing this as "Will Hawkins <whh8b@obs.cr>" ?

hawkinsw added a comment.Aug 23 2023, 9:40 AM
In D158446#4610369, @Mordante wrote:
In D158446#4607932, @hawkinsw wrote:
In D158446#4607682, @Mordante wrote:

Can you provide your user name and email address so I can land it on your behalf?

Thank you!!

hawkinsw
whh8b@obs.cr

Thank you!

In general we prefer real names. Are you fine with committing this as "Will Hawkins <whh8b@obs.cr>" ?

Absolutely 100%! The only reason that I said hawkinsw was because of your reference to "user name". I prefer my real name! Sorry for the confusion!

Will

Closed by commit rG3db0e400f0a9: [libcxx][NFC] Update status documentation for stride range view (authored by hawkinsw, committed by Mordante). · Explain WhyAug 23 2023, 10:28 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG3db0e400f0a9: [libcxx][NFC] Update status documentation for stride range view.

Revision Contents

PathSize
libcxx/
docs/
Status/
2 lines

Diff 552103

libcxx/docs/Status/RangesViews.csv

Show All 28 Lines
C++23,`adjacent <https://wg21.link/P2321R2>`_,Hui Xie,No patch yet,Not started C++23,`adjacent <https://wg21.link/P2321R2>`_,Hui Xie,No patch yet,Not started
C++23,`adjacent_transform <https://wg21.link/P2321R2>`_,Hui Xie,No patch yet,Not started C++23,`adjacent_transform <https://wg21.link/P2321R2>`_,Hui Xie,No patch yet,Not started
C++23,`join_with <https://wg21.link/P2441R2>`_,Unassigned,No patch yet,Not started C++23,`join_with <https://wg21.link/P2441R2>`_,Unassigned,No patch yet,Not started
C++23,`slide <https://wg21.link/P2442R1>`_,Unassigned,No patch yet,Not started C++23,`slide <https://wg21.link/P2442R1>`_,Unassigned,No patch yet,Not started
C++23,`chunk <https://wg21.link/P2442R1>`_,Unassigned,No patch yet,Not started C++23,`chunk <https://wg21.link/P2442R1>`_,Unassigned,No patch yet,Not started
C++23,`chunk_by <https://wg21.link/P2443R1>`_,Unassigned,No patch yet,Not started C++23,`chunk_by <https://wg21.link/P2443R1>`_,Unassigned,No patch yet,Not started
C++23,`as_const <https://wg21.link/P2278R4>`_,Unassigned,No patch yet,Not started C++23,`as_const <https://wg21.link/P2278R4>`_,Unassigned,No patch yet,Not started
C++23,`as_rvalue <https://wg21.link/P2446R2>`_,Nikolas Klauser,`D137637 <https://llvm.org/D137637>`_,✅ C++23,`as_rvalue <https://wg21.link/P2446R2>`_,Nikolas Klauser,`D137637 <https://llvm.org/D137637>`_,✅
C++23,`stride <https://wg21.link/P1899R3>`_,Hristo Hristov,No patch yet,In Progress C++23,`stride <https://wg21.link/P1899R3>`_,Hristo Hristov and Will Hawkins,`D156924 <https://llvm.org/D156924>`_,In Progress
C++23,`enumerate <https://wg21.link/P2164R9>`_,Hristo Hristov,No patch yet,In Progress C++23,`enumerate <https://wg21.link/P2164R9>`_,Hristo Hristov,No patch yet,In Progress