- User Since
- Mar 16 2022, 6:06 AM (9 w, 5 d)
Fri, May 20
I realize the reason for the failure. It would appear that there are tests that are otherwise affected by the change in the behavior introduced here. I will take care of updating these tests as quickly as possible. I am sorry for the trouble, @JDevlieghere !
I am going to investigate why the buildbot failed. When I ran the tests locally everything ran fine. I am terribly, terribly sorry!
Thu, May 19
@JDevlieghere So sorry! I cannot believe I missed those. Thanks for putting up with me!
Stupidly missed a few of the places where bare assertions were used.
Tue, May 17
Fri, May 13
@JDevlieghere Thanks again for the feedback. I updated the patchset according to your comments. I left open one of your suggestions to get your feedback.
Updating the patchset according to the helpful feedback from @JDevlieghere.
Wed, May 11
I hope that those minor edits help at least a little!
Sorry to bother you all (@jingham, @JDevlieghere and @labath), but I just wondered if there was anything else that I could do to spruce this up! I want to make sure that it meets everyone's expectations! It's been awesome to work on this submission!
Mon, May 9
Just trying to be helpful!
Fri, May 6
(for real) Updating the patch based on helpful feedback from @jingham.
Updated patch including responses to helpful feedback from @jingham.
Thu, May 5
Wed, May 4
As always, thank you for the work that you all do on lldb! An amazing tool! It is so much fun to be able to help and I hope that this is a helpful addition. Please let me know whether this is something that you find useful and whether or not there are changes that I can make to get this patch acceptable!
Tue, May 3
Mon, May 2
Sun, May 1
First, a thank you from a long-time gdb user who has finally seen the light and working to switch to lldb! The work that you all do to build an awesome, modern debugger is amazing.
Mon, Apr 25
Added that extra space, as requested! And, yes, I will need someone to land this one for me. I am going to ask for commit access, but so far have not! Thanks for your help, @JDevlieghere !
Updating thanks to @JDevlieghere feedback!
Sat, Apr 23
Mar 16 2022
I hope I didn't spam you all with asking for a review. It seems you are recently committers to this file. I am a long-time user, first-time contributor. I hope I am following best practices.