- User Since
- Mar 16 2022, 6:06 AM (80 w, 5 d)
Wed, Sep 6
Migrated to GitHub: https://github.com/llvm/llvm-project/pull/65531
Sep 1 2023
In light of the transition to GitHub PRs, I am closing this revision in favor of https://github.com/llvm/llvm-project/pull/65200.
Add tests for enable_borrowed_range.
Aug 31 2023
I hope that some comments are helpful! The documentation that you added is tremendously helpful -- I know how documentation is sometimes a thankless task, so I will say what everyone is thinking: "THANK YOU".
Aug 23 2023
Aug 22 2023
Aug 21 2023
Hope that I followed proper protocol! Thanks, everyone!
Adding some tests (generally making progress).
Aug 11 2023
Add iterator operator== tests.
Aug 9 2023
Prevent __to_unsigned_like from using ADL.
@H-G-Hristov Thank you for all the contributions -- your code was immensely helpful. I think that I am making some progress! If you have any thoughts on the way that things are going with the implementation, please let me know! Thanks again!
Clean up the skeleton test file (remove references to std::ranges::enumerate).
(maybe) last clang-tidy/format and add base tests.
Aug 8 2023
Add initial tests for ::size
Make div-ceil system only by adding __ prefix.
Aug 7 2023
Adding some missing include files.
Check in the modified feature test macro code.
More cargo crating from @H-G-Hristov's excellent work.
Bring in the awesome tests that @H-G-Hristov already wrote!
Fix some ADL warnings, compilation errors and implementation details.
Updating to better use bootstrap instead of runtimes based on @ldionne's feedback!
Aug 5 2023
Aug 4 2023
Added a first, basic test and also did some more clang-tidy'ing.
clang-tidy'd the code.
Remove inclusion of spurious change to libcxx-lit.
Aug 3 2023
Fixed the commit against which this diff should be applied.
Marked div_ceil as ABI invisible and removed caching.
Incorrectly marked the patch as libc and not libc++.
Hello everyone! It took me a bit to figure out that cxx-test-depends needed to be runtimes-test-depends and where/how to change that when using the libcxx-lit and thought that this little change might help!
Aug 2 2023
Thank you, @Mordante !
Formatted patch using clang-format on @Mordante 's helpful suggestion.
Nov 8 2022
Oct 28 2022
Thank you for the kind response -- I hope my work was helpful! It was lots of fun to dig in to this part of the codebase!
Oct 26 2022
If you would like, I'd be happy to reopen this patch as a separate issue if that's the better way to handle it! Sorry for the SPAM!
Oct 25 2022
There are *so* many reasons that I love this patch.
Oct 24 2022
I updated this revision with the following change and I *think* that things are happy again:
Oct 23 2022
Sep 8 2022
Sep 5 2022
I hope that these comments are helpful. If they are not, please feel free to tell me to stop! I appreciated learning from reading through your discussion with @labath !
Sep 3 2022
Aug 31 2022
Sorry if these comments are not helpful! Everything looks great!
Aug 16 2022
Aug 8 2022
Aug 6 2022
Aug 5 2022
Not that my opinion means much, but the changes look good to me.
Jul 7 2022
Jun 10 2022
Jun 4 2022
Jun 3 2022
May 30 2022
Updating to address @jloser comment about comma after however as conjunctive adverb.
May 29 2022
Updating after excellent feedback from @jloser.
May 27 2022
May 25 2022
Updating the revision to consider feedback (!= None vs is not None)
May 24 2022
@DavidSpickett Thanks (again) for the feedback. Once I fix the nit, is the proper protocol for you to review again? I am sorry to ask but I don't know the right procedure and don't want to do the wrong thing!
May 23 2022
@DavidSpickett Thank you for the review! I hope that this 2nd version of the patch addresses your helpful comments!
Updating based on DavidSpickett helpful feedback.
May 20 2022
I realize the reason for the failure. It would appear that there are tests that are otherwise affected by the change in the behavior introduced here. I will take care of updating these tests as quickly as possible. I am sorry for the trouble, @JDevlieghere !
I am going to investigate why the buildbot failed. When I ran the tests locally everything ran fine. I am terribly, terribly sorry!
May 19 2022
@JDevlieghere So sorry! I cannot believe I missed those. Thanks for putting up with me!
Stupidly missed a few of the places where bare assertions were used.
May 17 2022
May 13 2022
@JDevlieghere Thanks again for the feedback. I updated the patchset according to your comments. I left open one of your suggestions to get your feedback.
Updating the patchset according to the helpful feedback from @JDevlieghere.
May 11 2022
I hope that those minor edits help at least a little!
Sorry to bother you all (@jingham, @JDevlieghere and @labath), but I just wondered if there was anything else that I could do to spruce this up! I want to make sure that it meets everyone's expectations! It's been awesome to work on this submission!
May 9 2022
Just trying to be helpful!
May 6 2022
(for real) Updating the patch based on helpful feedback from @jingham.