Page MenuHomePhabricator

hawkinsw (Will Hawkins)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2022, 6:06 AM (9 w, 5 d)

Recent Activity

Fri, May 20

hawkinsw requested review of D126109: [lldb] Fix broken bad-address-breakpoint test.
Fri, May 20, 7:01 PM · Unknown Object (Project), Restricted Project
hawkinsw added a comment to D124731: [lldb] Consider binary as module of last resort.

I realize the reason for the failure. It would appear that there are tests that are otherwise affected by the change in the behavior introduced here. I will take care of updating these tests as quickly as possible. I am sorry for the trouble, @JDevlieghere !

Fri, May 20, 2:35 PM · Unknown Object (Project), Restricted Project
hawkinsw added a comment to D124731: [lldb] Consider binary as module of last resort.

I am going to investigate why the buildbot failed. When I ran the tests locally everything ran fine. I am terribly, terribly sorry!

Fri, May 20, 2:27 PM · Unknown Object (Project), Restricted Project
hawkinsw added a comment to D124731: [lldb] Consider binary as module of last resort.

Please let me know if you need someone to land this on your behalf.

Fri, May 20, 1:36 PM · Unknown Object (Project), Restricted Project

Thu, May 19

hawkinsw added a comment to D124731: [lldb] Consider binary as module of last resort.

@JDevlieghere So sorry! I cannot believe I missed those. Thanks for putting up with me!

Thu, May 19, 1:02 PM · Unknown Object (Project), Restricted Project
hawkinsw updated the diff for D124731: [lldb] Consider binary as module of last resort.

Stupidly missed a few of the places where bare assertions were used.

Thu, May 19, 1:00 PM · Unknown Object (Project), Restricted Project

Tue, May 17

hawkinsw added a comment to D124731: [lldb] Consider binary as module of last resort.

Just wanted to see if there was anything else I could do to help make this patch acceptable, @JDevlieghere and @jingham . Thanks again for all your help!

Tue, May 17, 9:20 AM · Unknown Object (Project), Restricted Project

Fri, May 13

hawkinsw added a comment to D124731: [lldb] Consider binary as module of last resort.

@JDevlieghere Thanks again for the feedback. I updated the patchset according to your comments. I left open one of your suggestions to get your feedback.

Fri, May 13, 10:16 PM · Unknown Object (Project), Restricted Project
hawkinsw updated the diff for D124731: [lldb] Consider binary as module of last resort.

Updating the patchset according to the helpful feedback from @JDevlieghere.

Fri, May 13, 10:15 PM · Unknown Object (Project), Restricted Project
hawkinsw added inline comments to D124731: [lldb] Consider binary as module of last resort.
Fri, May 13, 10:10 PM · Unknown Object (Project), Restricted Project
hawkinsw added a comment to D124731: [lldb] Consider binary as module of last resort.

Hello @labath and @JDevlieghere -- I hope that your Friday is going well! I'd love to make any other changes to this if necessary! Thanks for everything!

Fri, May 13, 6:55 AM · Unknown Object (Project), Restricted Project

Wed, May 11

hawkinsw added a comment to D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions.

I hope that those minor edits help at least a little!

Wed, May 11, 9:25 PM · Unknown Object (Project), Restricted Project
hawkinsw added a comment to D124731: [lldb] Consider binary as module of last resort.

Sorry to bother you all (@jingham, @JDevlieghere and @labath), but I just wondered if there was anything else that I could do to spruce this up! I want to make sure that it meets everyone's expectations! It's been awesome to work on this submission!

Wed, May 11, 7:01 AM · Unknown Object (Project), Restricted Project

Mon, May 9

hawkinsw added a comment to D125148: Add an example command that runs to one of a set of breakpoints.

Just trying to be helpful!

Mon, May 9, 4:03 PM · Unknown Object (Project), Restricted Project

Fri, May 6

hawkinsw added a comment to D124731: [lldb] Consider binary as module of last resort.

(for real) Updating the patch based on helpful feedback from @jingham.

Fri, May 6, 5:03 PM · Unknown Object (Project), Restricted Project
hawkinsw updated the diff for D124731: [lldb] Consider binary as module of last resort.

(for real) Updating the patch based on helpful feedback from @jingham.

Fri, May 6, 4:59 PM · Unknown Object (Project), Restricted Project
hawkinsw updated the diff for D124731: [lldb] Consider binary as module of last resort.

Updated patch including responses to helpful feedback from @jingham.

Fri, May 6, 4:56 PM · Unknown Object (Project), Restricted Project

Thu, May 5

hawkinsw added a comment to D124731: [lldb] Consider binary as module of last resort.

This seems like a reasonable fallback, and the implementation looks fine.
You need to add a test case setting an address breakpoint in the executable and making sure that works. Should be easy, set a line breakpoint in the main executable, get the resolved address and set an address breakpoint with that and make sure that breakpoint got a location.
You should also add some words to the "break set" command help saying that this is the fallback behavior.

Thu, May 5, 5:46 PM · Unknown Object (Project), Restricted Project

Wed, May 4

hawkinsw added a reviewer for D124731: [lldb] Consider binary as module of last resort: labath.
Wed, May 4, 11:10 AM · Unknown Object (Project), Restricted Project
hawkinsw added a comment to D124922: [lldb] Inject commands into log output when directed to file.

Heh, well.. there definitely are, though a lot of things that come to mind right now are not really suitable for a first-time contributor. Is there any specific are that you would like to know (or that you know already)?

One of the things that I ran into recently, but hadn't had time to fix is the relocation processing code in ObjectFileELF::ApplyRelocations. It's currently fairly messy, and mixes relocations of different architectures (which generally doesn't work as different constants mean different things depending on the architecture. If you could refactor the function such that it has a clear split between architectures, and still allows for code sharing for relocations that mean the same thing on each architecture, then that would be greatly appreciated.

You can try that out by compiling a .o file for some non-x86 architecture and checking whether lldb can read the debug info without asserting.

Wed, May 4, 8:47 AM · Unknown Object (Project), Restricted Project
hawkinsw added a comment to D124922: [lldb] Inject commands into log output when directed to file.

Yeah, I guess that what I am saying.

For me the commands channel gives 6 lines of output for a command. Compared to what some of our other logging channels do, that's nothing.

Wed, May 4, 8:24 AM · Unknown Object (Project), Restricted Project
hawkinsw added a comment to D124922: [lldb] Inject commands into log output when directed to file.

Just my opinion, but I wouldn't like to complicate the logging architecture with file-only log statements and cross-channel dependencies. If you want to cross-reference some other logging channel with the executed commands then I'd say you should enable both channels. We can definitely talk about making the command feature more prominently in the log stream.

Wed, May 4, 8:14 AM · Unknown Object (Project), Restricted Project
hawkinsw added a comment to D124922: [lldb] Inject commands into log output when directed to file.

As always, thank you for the work that you all do on lldb! An amazing tool! It is so much fun to be able to help and I hope that this is a helpful addition. Please let me know whether this is something that you find useful and whether or not there are changes that I can make to get this patch acceptable!

Wed, May 4, 6:46 AM · Unknown Object (Project), Restricted Project
hawkinsw requested review of D124922: [lldb] Inject commands into log output when directed to file.
Wed, May 4, 6:44 AM · Unknown Object (Project), Restricted Project

Tue, May 3

hawkinsw removed a reviewer for D124731: [lldb] Consider binary as module of last resort: tatyana-krasnukha.
Tue, May 3, 3:33 PM · Unknown Object (Project), Restricted Project

Mon, May 2

hawkinsw added a reviewer for D124731: [lldb] Consider binary as module of last resort: JDevlieghere.
Mon, May 2, 8:37 AM · Unknown Object (Project), Restricted Project

Sun, May 1

hawkinsw added a comment to D124731: [lldb] Consider binary as module of last resort.

First, a thank you from a long-time gdb user who has finally seen the light and working to switch to lldb! The work that you all do to build an awesome, modern debugger is amazing.

Sun, May 1, 12:08 AM · Unknown Object (Project), Restricted Project
hawkinsw requested review of D124731: [lldb] Consider binary as module of last resort.
Sun, May 1, 12:05 AM · Unknown Object (Project), Restricted Project

Mon, Apr 25

hawkinsw added a comment to D124338: [lldb] Update online help text (consistency, typo).

Added that extra space, as requested! And, yes, I will need someone to land this one for me. I am going to ask for commit access, but so far have not! Thanks for your help, @JDevlieghere !

Mon, Apr 25, 2:34 PM · Unknown Object (Project), Restricted Project
hawkinsw updated the diff for D124338: [lldb] Update online help text (consistency, typo).

Updating thanks to @JDevlieghere feedback!

Mon, Apr 25, 2:33 PM · Unknown Object (Project), Restricted Project
hawkinsw added a reviewer for D124338: [lldb] Update online help text (consistency, typo): labath.
Mon, Apr 25, 6:18 AM · Unknown Object (Project), Restricted Project

Sat, Apr 23

hawkinsw added a comment to D124338: [lldb] Update online help text (consistency, typo).

I hope that I didn't SPAM you, @teemperor and @JDevlieghere ! Thanks for all that you do for the LLVM community!

Sat, Apr 23, 4:36 PM · Unknown Object (Project), Restricted Project
hawkinsw requested review of D124338: [lldb] Update online help text (consistency, typo).
Sat, Apr 23, 4:35 PM · Unknown Object (Project), Restricted Project

Mar 16 2022

hawkinsw added a comment to D121802: [LLDB] Fix typos in LLDB help output..

I think you're doing everything right. Thanks for the fixes. I can commit this together with the other patch.

Mar 16 2022, 7:18 AM · Unknown Object (Project), Restricted Project
hawkinsw added a comment to D121800: [LLDB] Change enumaration to enumeration.

Looks good. I presume you need someone to commit this for you (?) What's the name&email I can use for commit attribution?

Mar 16 2022, 6:56 AM · Unknown Object (Project), Restricted Project
hawkinsw added a comment to D121802: [LLDB] Fix typos in LLDB help output..

I hope I didn't spam you all with asking for a review. It seems you are recently committers to this file. I am a long-time user, first-time contributor. I hope I am following best practices.

Mar 16 2022, 6:53 AM · Unknown Object (Project), Restricted Project
hawkinsw requested review of D121802: [LLDB] Fix typos in LLDB help output..
Mar 16 2022, 6:52 AM · Unknown Object (Project), Restricted Project
hawkinsw requested review of D121800: [LLDB] Change enumaration to enumeration.
Mar 16 2022, 6:45 AM · Unknown Object (Project), Restricted Project