[mlir] Fully qualify typenames in SymbolInterfaces.td

[zero9178]

LGTM!

Covention is to put something like [mlir] in the commit title to quickly establish some context :)

Do you need this to be committed for you? If yes, what "name <email>" should be used?

[shkoo]

In D158305#4599883, @zero9178 wrote:

Do you need this to be committed for you? If yes, what "name <email>" should be used?

Yes please! Nils McCarthy <[e-mail]>

Thanks!

[jbruestle]

Looks good!

mlir/include/mlir/IR/SymbolInterfaces.td

let description = [{
     operation resides immediately within a region that defines a `SymbolTable`.
     See [Symbols and SymbolTables](../SymbolsAndSymbolTables.md) for more details
     and constraints on `Symbol` operations.
   }];
   let cppNamespace = "::mlir";
 
   let methods = [
     InterfaceMethod<"Returns the name of this symbol.",
-      "StringAttr", "getNameAttr", (ins), [{
+      "::mlir::StringAttr", "getNameAttr", (ins), [{
         // Don't rely on the trait implementation as optional symbol operations
         // may override this.
         return mlir::SymbolTable::getSymbolName($_op);
       }], /*defaultImplementation=*/[{
         return mlir::SymbolTable::getSymbolName(this->getOperation());
       }]
     >,
     InterfaceMethod<"Sets the name of this symbol.",
if (concreteOp.isDeclaration() && concreteOp.isPublic())
              "visibility");
     return success();
   }];
 
   let extraSharedClassDeclaration = [{
     using Visibility = mlir::SymbolTable::Visibility;
 
     /// Convenience version of `getNameAttr` that returns a StringRef.
-    StringRef getName() {
+    ::mlir::StringRef getName() {
       return getNameAttr().getValue();
     }
 
     /// Convenience version of `setName` that take a StringRef.
-    void setName(StringRef name) {
-      setName(StringAttr::get($_op->getContext(), name));
+    void setName(::mlir::StringRef name) {
+      setName(::mlir::StringAttr::get($_op->getContext(), name));
     }
   }];
 
   // Add additional classof checks to properly handle "optional" symbols.
   let extraClassOf = [{
     return $_op->hasAttr(::mlir::SymbolTable::getSymbolAttrName());
   }];
 }