This is an archive of the discontinued LLVM Phabricator instance.

[clang] EditedSource::applyRewrites - useless call
ClosedPublic

Authored by Manna on Aug 17 2023, 3:45 PM.

Diff Detail

Event Timeline

Manna created this revision.Aug 17 2023, 3:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 3:45 PM
Manna requested review of this revision.Aug 17 2023, 3:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 3:45 PM
aaron.ballman accepted this revision.Aug 18 2023, 6:00 AM

LGTM! This is an NFC change that doesn't require additional testing because CurEnd is only used in an assertion, not for any of the function's semantics.

This revision is now accepted and ready to land.Aug 18 2023, 6:00 AM
Manna added a comment.Aug 22 2023, 7:29 AM

Thank you @aaron.ballman for reviews and feedbacks.

This revision was landed with ongoing or failed builds.Aug 23 2023, 7:39 AM
This revision was automatically updated to reflect the committed changes.
Manna added a comment.Aug 23 2023, 7:40 AM

The failure seems unrelated to my change.

dyung added a subscriber: dyung.Aug 23 2023, 8:20 AM

The failure seems unrelated to my change.

Hi @Manna, I'm not sure which failure you are referring to, but there is a test failure on at least 2 build bots that seems to have been caused by your change. Can you take a look and revert if you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/139/builds/48141
https://lab.llvm.org/buildbot/#/builders/216/builds/26116

Manna added a comment.Aug 23 2023, 8:37 AM

The failure seems unrelated to my change.

Hi @Manna, I'm not sure which failure you are referring to, but there is a test failure on at least 2 build bots that seems to have been caused by your change. Can you take a look and revert if you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/139/builds/48141
https://lab.llvm.org/buildbot/#/builders/216/builds/26116

Thank you @dyung for reporting the buildbot failure. I have reverted my patch. I will investigate it.