This is an archive of the discontinued LLVM Phabricator instance.

Differential D158028

[Sanitizers][Driverkit] Stop using Sanitizer Allocator64 on Driverkit
ClosedPublic

Authored by thetruestblue on Aug 15 2023, 2:59 PM.

Details

Reviewers
yln
kubamracek
rsundahl
wrotki
usama54321
Commits
rGb5c2075081b7: [Sanitizers][Driverkit] Stop using Sanitizer Allocator64 on Driverkit
Summary

Before refactoring this code, all arm64 were set to use the 32bit allocator. This patch reverts back that behavior for DriverKit.

Because we target DriverKit as the target OS, rather than a specific platform, reverting back to the previous behavior is preferred to fix a failure we are seeing on embedded platforms.
Though it may be more correct in the future to match the allocator to the platform being used.

rdar://113649286

Diff Detail

Event Timeline

thetruestblue created this revision.Aug 15 2023, 2:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 2:59 PM
Herald added subscribers: Enna1, s.egerton, simoncook and 2 others. · View Herald Transcript
thetruestblue requested review of this revision.Aug 15 2023, 2:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 2:59 PM
Herald added subscribers: Restricted Project, wangpc. · View Herald Transcript
thetruestblue added a reviewer: usama54321.Aug 15 2023, 3:06 PM
Harbormaster completed remote builds in B252762: Diff 550493.Aug 15 2023, 3:56 PM
yln accepted this revision.Aug 15 2023, 4:48 PM
This revision is now accepted and ready to land.Aug 15 2023, 4:48 PM
wrotki accepted this revision.Aug 15 2023, 9:05 PM

LGTM

rsundahl accepted this revision.Aug 15 2023, 9:10 PM

This looks good @thetruestblue... It should just revert the change for DriverKit which was passing prior the this change.

Closed by commit rGb5c2075081b7: [Sanitizers][Driverkit] Stop using Sanitizer Allocator64 on Driverkit (authored by Blue Gaston <bgaston2@apple.com>). · Explain WhyAug 16 2023, 11:30 AM
This revision was automatically updated to reflect the committed changes.
Blue Gaston <bgaston2@apple.com> added a commit: rGb5c2075081b7: [Sanitizers][Driverkit] Stop using Sanitizer Allocator64 on Driverkit.

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
2 lines

Diff 550827

compiler-rt/lib/sanitizer_common/sanitizer_platform.h

Show First 20 Lines • Show All 278 Lines • ▼ Show 20 Lines
#endif #endif
// By default we allow to use SizeClassAllocator64 on 64-bit platform. // By default we allow to use SizeClassAllocator64 on 64-bit platform.
// But in some cases SizeClassAllocator64 does not work well and we need to // But in some cases SizeClassAllocator64 does not work well and we need to
// fallback to SizeClassAllocator32. // fallback to SizeClassAllocator32.
// For such platforms build this code with -DSANITIZER_CAN_USE_ALLOCATOR64=0 or // For such platforms build this code with -DSANITIZER_CAN_USE_ALLOCATOR64=0 or
// change the definition of SANITIZER_CAN_USE_ALLOCATOR64 here. // change the definition of SANITIZER_CAN_USE_ALLOCATOR64 here.
#ifndef SANITIZER_CAN_USE_ALLOCATOR64 #ifndef SANITIZER_CAN_USE_ALLOCATOR64
# if SANITIZER_RISCV64 || SANITIZER_IOS # if SANITIZER_RISCV64 || SANITIZER_IOS || SANITIZER_DRIVERKIT
# define SANITIZER_CAN_USE_ALLOCATOR64 0 # define SANITIZER_CAN_USE_ALLOCATOR64 0
# elif defined(__mips64) || defined(__hexagon__) # elif defined(__mips64) || defined(__hexagon__)
# define SANITIZER_CAN_USE_ALLOCATOR64 0 # define SANITIZER_CAN_USE_ALLOCATOR64 0
# else # else
# define SANITIZER_CAN_USE_ALLOCATOR64 (SANITIZER_WORDSIZE == 64) # define SANITIZER_CAN_USE_ALLOCATOR64 (SANITIZER_WORDSIZE == 64)
# endif # endif
#endif #endif
▲ Show 20 Lines • Show All 153 Lines • Show Last 20 Lines