This is an archive of the discontinued LLVM Phabricator instance.

[SPIRV] Share a test between DXIL & SPIRV backends
AbandonedPublic

Authored by Keenuts on Aug 15 2023, 3:26 AM.

Details

Reviewers
beanz
mpaszkowski
Summary

The SPIR-V backend is not ready yet to compile graphic shaders. So we
have no test that could pass with both backends except this one.

But in the future, we'd have 2 backends available for the HLSL
frontend: DXIL and SPIRV.
In DirectXShaderCompiler, a common source of bugs was uneven coverage
of features between both backends.
The goal here is to determine the canonical way to share tests.

The main issue is around XFAIL: in an ideal world, we could link
each XFAIL to a RUN line, but right now it's not possible.
This means we cannot mark the test as XFAIL just for 1 backend.

Diff Detail

Event Timeline

Keenuts created this revision.Aug 15 2023, 3:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 3:26 AM
Keenuts requested review of this revision.Aug 15 2023, 3:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 3:26 AM

Hello!
For now this only changes a test in the SPIR-V backend, but the idea would be to do the same on the DXIL backend as we bring support 😊

All the best,

Keenuts abandoned this revision.Sep 12 2023, 4:41 AM

Abandoning this one. We'll probably end-up doing a test/HLSL folder to share common tests with the DXIL backend.