[sanitizer] Add CMake flag to build with internal symbolizer

[vitalybuka]

Summary

This intermediate result in moving internal symbolizer build
from sh script to CMake rules.

The flag is supposed to be used with:
-DLLVM_ENABLE_PROJECTS="clang;lld;compiler-rt" -DLLVM_ENABLE_RUNTIMES="libunwind;libcxx;libcxxabi" -Sllvm-project/llvm

After converting sh script into cmake, we may add support for other build modes.

For https://github.com/llvm/llvm-project/issues/30098

[vitalybuka]

rebase

[Enna1]

Thanks for working on this, this is a real useful feature!

IIUR, for the long term, we will replace current intermediate result (execute build_symbolizer.sh with CMake add_custom_command) with pure CMake rules?

We have add_custom_libcxx in compiler-rt/cmake/Modules/AddCompilerRT.cmake, so I think we can add add_custom_llvm in compiler-rt/cmake/Modules/AddCompilerRT.cmake.
Then we can use add_custom_libcxx and add_custom_llvm in compiler-rt/lib/sanitizer_common/symbolizer/CMakeLists.txt to build LLVMSymbolize like we do in build_symbolizer.sh.

[vitalybuka]

In D157947#4587354, @Enna1 wrote:

Thanks for working on this, this is a real useful feature!

IIUR, for the long term, we will replace current intermediate result (execute build_symbolizer.sh with CMake add_custom_command) with pure CMake rules?

We have add_custom_libcxx in compiler-rt/cmake/Modules/AddCompilerRT.cmake, so I think we can add add_custom_llvm in compiler-rt/cmake/Modules/AddCompilerRT.cmake.
Then we can use add_custom_libcxx and add_custom_llvm in compiler-rt/lib/sanitizer_common/symbolizer/CMakeLists.txt to build LLVMSymbolize like we do in build_symbolizer.sh.

Yes. Actually I tried that in one patch and it's getting ugly. So I decide to lock parts which work and get back to the rest later.

[MaskRay]

Can you describe how to specify COMPILER_RT_INTERNAL_SYMBOLIZER_ZLIB_SRC= in the summary/commit message?

[MaskRay]

This does not work with -Scompiler-rt:

% (cd /tmp/p; git clone https://github.com/madler/zlib.git)
% cmake -GNinja -Scompiler-rt -B/tmp/out/rt-x86_64 -DCMAKE_C_COMPILER=/tmp/Rel/bin/clang -DCMAKE_CXX_COMPILER=/tmp/Rel/bin/clang++ -DLLVM_CMAKE_DIR=/tmp/Rel -DLLVM_APPEND_VC_REV=OFF -DCMAKE_C{,XX}_COMPILER_TARGET=x86_64-unknown-linux-gnu -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on -DCOMPILER_RT_DEFAULT_TARGET_ONLY=on -DCOMPILER_RT_HAS_LLD=on -DCOMPILER_RT_TEST_USE_LLD=on -DCOMPILER_RT_INCLUDE_TESTS=on -DCOMPILER_RT_ENABLE_INTERNAL_SYMBOLIZER=on -DCOMPILER_RT_INTERNAL_SYMBOLIZER_ZLIB_SRC=/tmp/p/zlib
% ninja -C /tmp/out/rt-x86_64
ninja: Entering directory `/tmp/out/rt-x86_64'
ninja: error: 'lib/sanitizer_common/symbolizer/clang', needed by 'lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.x86_64.o', missing and no known rule to make it

Perhaps you can mention that zstd is not used at the present.

The following works. Is RTSanitizerCommonSymbolizerInternalObj.x86_64 the intended final target name?

% cmake -GNinja -Sllvm -B/tmp/out/custom -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS='clang;lld;compiler-rt' -DCOMPILER_RT_ENABLE_INTERNAL_SYMBOLIZER=on -DCOMPILER_RT_INTERNAL_SYMBOLIZER_ZLIB_SRC=/tmp/p/zlib
% ninja -C /tmp/out/custom RTSanitizerCommonSymbolizerInternalObj.x86_64

[vitalybuka]

In D157947#4590579, @MaskRay wrote:

This does not work with -Scompiler-rt:

% (cd /tmp/p; git clone https://github.com/madler/zlib.git)
% cmake -GNinja -Scompiler-rt -B/tmp/out/rt-x86_64 -DCMAKE_C_COMPILER=/tmp/Rel/bin/clang -DCMAKE_CXX_COMPILER=/tmp/Rel/bin/clang++ -DLLVM_CMAKE_DIR=/tmp/Rel -DLLVM_APPEND_VC_REV=OFF -DCMAKE_C{,XX}_COMPILER_TARGET=x86_64-unknown-linux-gnu -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on -DCOMPILER_RT_DEFAULT_TARGET_ONLY=on -DCOMPILER_RT_HAS_LLD=on -DCOMPILER_RT_TEST_USE_LLD=on -DCOMPILER_RT_INCLUDE_TESTS=on -DCOMPILER_RT_ENABLE_INTERNAL_SYMBOLIZER=on -DCOMPILER_RT_INTERNAL_SYMBOLIZER_ZLIB_SRC=/tmp/p/zlib
% ninja -C /tmp/out/rt-x86_64
ninja: Entering directory `/tmp/out/rt-x86_64'
ninja: error: 'lib/sanitizer_common/symbolizer/clang', needed by 'lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.x86_64.o', missing and no known rule to make it

It does not suppose to work as we expect full llvm tree.

Perhaps you can mention that zstd is not used at the present.

The following works. Is RTSanitizerCommonSymbolizerInternalObj.x86_64 the intended final target name?

% cmake -GNinja -Sllvm -B/tmp/out/custom -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS='clang;lld;compiler-rt' -DCOMPILER_RT_ENABLE_INTERNAL_SYMBOLIZER=on -DCOMPILER_RT_INTERNAL_SYMBOLIZER_ZLIB_SRC=/tmp/p/zlib
% ninja -C /tmp/out/custom RTSanitizerCommonSymbolizerInternalObj.x86_64

[vitalybuka]

remove zlib option

[MaskRay]

If -DCLANG_DEFAULT_RTLIB=compiler-rt -DCLANG_DEFAULT_UNWINDLIB=libunwind -DCLANG_DEFAULT_CXX_STDLIB=libc++ is used, unwind builtins should also be added as a depdency, otherwise we may have a linker error if unwind builtins haven't been built. I suspect that cxx cxxabi are similar.

compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh

179

remove trailing space

[vitalybuka]

space

[vitalybuka]

In D157947#4590634, @MaskRay wrote:

If -DCLANG_DEFAULT_RTLIB=compiler-rt -DCLANG_DEFAULT_UNWINDLIB=libunwind -DCLANG_DEFAULT_CXX_STDLIB=libc++ is used, unwind builtins should also be added as a depdency, otherwise we may have a linker error if unwind builtins haven't been built. I suspect that cxx cxxabi are similar.

In D157947#4590634, @MaskRay wrote:

If -DCLANG_DEFAULT_RTLIB=compiler-rt -DCLANG_DEFAULT_UNWINDLIB=libunwind -DCLANG_DEFAULT_CXX_STDLIB=libc++ is used, unwind builtins should also be added as a dependency, otherwise we may have a linker error if unwind builtins haven't been built. I suspect that cxx cxxabi are similar.

Not sure I understand, RTSanitizerCommonSymbolizerInternal.${arch}.o should not depend on unwind.
Or your commend about top level cmake invocation in the description?

[MaskRay]

In D157947#4590667, @vitalybuka wrote:

In D157947#4590634, @MaskRay wrote:

If -DCLANG_DEFAULT_RTLIB=compiler-rt -DCLANG_DEFAULT_UNWINDLIB=libunwind -DCLANG_DEFAULT_CXX_STDLIB=libc++ is used, unwind builtins should also be added as a depdency, otherwise we may have a linker error if unwind builtins haven't been built. I suspect that cxx cxxabi are similar.

In D157947#4590634, @MaskRay wrote:

If -DCLANG_DEFAULT_RTLIB=compiler-rt -DCLANG_DEFAULT_UNWINDLIB=libunwind -DCLANG_DEFAULT_CXX_STDLIB=libc++ is used, unwind builtins should also be added as a dependency, otherwise we may have a linker error if unwind builtins haven't been built. I suspect that cxx cxxabi are similar.

Not sure I understand, RTSanitizerCommonSymbolizerInternal.${arch}.o should not depend on unwind.
Or your commend about top level cmake invocation in the description?

% cmake -GNinja -Sllvm -B/tmp/out/custom -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS='clang;lld;compiler-rt' -DLLVM_ENABLE_RUNTIMES='libcxx;libcxxabi;libunwind' -DCOMPILER_RT_ENABLE_INTERNAL_SYMBOLIZER=on -DCOMPILER_RT_INTERNAL_SYMBOLIZER_ZLIB_SRC=/tmp/p/zlib -DCLANG_DEFAULT_RTLIB=compiler-rt -DCLANG_DEFAULT_UNWINDLIB=libunwind -DCLANG_DEFAULT_CXX_STDLIB=libc++
% ninja -C /tmp/out/custom RTSanitizerCommonSymbolizerInternal.x86_64.o
...
-- Check for working C compiler: /tmp/out/custom/bin/clang - broken
CMake Error at /usr/share/cmake-3.25/Modules/CMakeTestCCompiler.cmake:70 (message):
  The C compiler

    "/tmp/out/custom/bin/clang"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /tmp/out/custom/projects/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.x86_64/symbolizer/libcxx/CMakeFiles/CMakeScratch/TryCompile-CTptMA

    Run Build Command(s):/usr/bin/ninja cmTC_769ed && [1/2] Building C object CMakeFiles/cmTC_769ed.dir/testCCompiler.c.o
    [2/2] Linking C executable cmTC_769ed
    FAILED: cmTC_769ed
    : && /tmp/out/custom/bin/clang   CMakeFiles/cmTC_769ed.dir/testCCompiler.c.o -o cmTC_769ed   && :
    ld.lld: error: cannot open /tmp/out/custom/lib/clang/18/lib/linux/libclang_rt.builtins-x86_64.a: No such file or directory
    ld.lld: error: unable to find library -lunwind
    ld.lld: error: cannot open /tmp/out/custom/lib/clang/18/lib/linux/libclang_rt.builtins-x86_64.a: No such file or directory
    ld.lld: error: unable to find library -lunwind
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    ninja: build stopped: subcommand failed.

I think we get ld.lld: error: cannot open /tmp/out/custom/lib/clang/18/lib/linux/libclang_rt.builtins-x86_64.a: No such file or directory etc because builtins and unwind are not built yet.

compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh

200

Q: How is the new RTSanitizerCommonSymbolizerInternal.${arch}.o injected into libclang_rt.*san*.a?

[vitalybuka]

% cmake -GNinja -Sllvm -B/tmp/out/custom -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS='clang;lld;compiler-rt' -DLLVM_ENABLE_RUNTIMES='libcxx;libcxxabi;libunwind' -DCOMPILER_RT_ENABLE_INTERNAL_SYMBOLIZER=on -DCOMPILER_RT_INTERNAL_SYMBOLIZER_ZLIB_SRC=/tmp/p/zlib -DCLANG_DEFAULT_RTLIB=compiler-rt -DCLANG_DEFAULT_UNWINDLIB=libunwind -DCLANG_DEFAULT_CXX_STDLIB=libc++
% ninja -C /tmp/out/custom RTSanitizerCommonSymbolizerInternal.x86_64.o
...
-- Check for working C compiler: /tmp/out/custom/bin/clang - broken
CMake Error at /usr/share/cmake-3.25/Modules/CMakeTestCCompiler.cmake:70 (message):
  The C compiler

    "/tmp/out/custom/bin/clang"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /tmp/out/custom/projects/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.x86_64/symbolizer/libcxx/CMakeFiles/CMakeScratch/TryCompile-CTptMA

    Run Build Command(s):/usr/bin/ninja cmTC_769ed && [1/2] Building C object CMakeFiles/cmTC_769ed.dir/testCCompiler.c.o
    [2/2] Linking C executable cmTC_769ed
    FAILED: cmTC_769ed
    : && /tmp/out/custom/bin/clang   CMakeFiles/cmTC_769ed.dir/testCCompiler.c.o -o cmTC_769ed   && :
    ld.lld: error: cannot open /tmp/out/custom/lib/clang/18/lib/linux/libclang_rt.builtins-x86_64.a: No such file or directory
    ld.lld: error: unable to find library -lunwind
    ld.lld: error: cannot open /tmp/out/custom/lib/clang/18/lib/linux/libclang_rt.builtins-x86_64.a: No such file or directory
    ld.lld: error: unable to find library -lunwind
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    ninja: build stopped: subcommand failed.

I see, I probably have it installed, so it does not fail on our bots and my workstation.

compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh

200

D157921

[vitalybuka]

compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh

200

Q: How is the new RTSanitizerCommonSymbolizerInternal.${arch}.o injected into libclang_rt.*san*.a?

D157921

If it's widely used, we could consider driver linking it.
So far it's quite niche, so probably not worth it.

[phosek]

This change broke our macOS builders (edb211cb78317ad73aa4bd2d3df75194b7f23a72 didn't help):

CMake Error at /opt/s/w/ir/x/w/llvm-llvm-project/compiler-rt/cmake/Modules/AddCompilerRT.cmake:357 (add_library):
  Error evaluating generator expression:

    $<TARGET_OBJECTS:RTSanitizerCommonSymbolizerInternal.osx>

  Objects of target "RTSanitizerCommonSymbolizerInternal.osx" referenced but
  no such target exists.
Call Stack (most recent call first):
  /opt/s/w/ir/x/w/llvm-llvm-project/compiler-rt/lib/stats/CMakeLists.txt:23 (add_compiler_rt_runtime)


CMake Error at /opt/s/w/ir/x/w/llvm-llvm-project/compiler-rt/cmake/Modules/AddCompilerRT.cmake:357 (add_library):
  Error evaluating generator expression:

    $<TARGET_OBJECTS:RTSanitizerCommonSymbolizerInternal.osx>

  Objects of target "RTSanitizerCommonSymbolizerInternal.osx" referenced but
  no such target exists.
Call Stack (most recent call first):
  /opt/s/w/ir/x/w/llvm-llvm-project/compiler-rt/lib/stats/CMakeLists.txt:23 (add_compiler_rt_runtime)


CMake Error at /opt/s/w/ir/x/w/llvm-llvm-project/compiler-rt/cmake/Modules/AddCompilerRT.cmake:357 (add_library):
  Error evaluating generator expression:

    $<TARGET_OBJECTS:RTSanitizerCommonSymbolizerInternal.osx>

  Objects of target "RTSanitizerCommonSymbolizerInternal.osx" referenced but
  no such target exists.
Call Stack (most recent call first):
  /opt/s/w/ir/x/w/llvm-llvm-project/compiler-rt/lib/stats/CMakeLists.txt:23 (add_compiler_rt_runtime)


CMake Error at /opt/s/w/ir/x/w/llvm-llvm-project/compiler-rt/cmake/Modules/AddCompilerRT.cmake:357 (add_library):
  No SOURCES given to target: clang_rt.stats_osx_dynamic
Call Stack (most recent call first):
  /opt/s/w/ir/x/w/llvm-llvm-project/compiler-rt/lib/stats/CMakeLists.txt:23 (add_compiler_rt_runtime)


CMake Generate step failed.  Build files cannot be regenerated correctly.

Would it be possible to take a look and revert if needed?

[JDevlieghere]

This broke the LLDB bot as well. I left a comment in https://github.com/llvm/llvm-project/commit/edb211cb78317ad73aa4bd2d3df75194b7f23a72. Given that this has been broken for a while I went ahead and reverted this: https://github.com/llvm/llvm-project/commit/0f50d0108c7ee8b081574a76816a428e30c6701a

[vitalybuka]

In D157947#4641936, @JDevlieghere wrote:

This broke the LLDB bot as well. I left a comment in https://github.com/llvm/llvm-project/commit/edb211cb78317ad73aa4bd2d3df75194b7f23a72. Given that this has been broken for a while I went ahead and reverted this: https://github.com/llvm/llvm-project/commit/0f50d0108c7ee8b081574a76816a428e30c6701a

Thanks for revert.

Do we have build bot so I can watch on the next attempt?

[vitalybuka]

In D157947#4642167, @vitalybuka wrote:

In D157947#4641936, @JDevlieghere wrote:

This broke the LLDB bot as well. I left a comment in https://github.com/llvm/llvm-project/commit/edb211cb78317ad73aa4bd2d3df75194b7f23a72. Given that this has been broken for a while I went ahead and reverted this: https://github.com/llvm/llvm-project/commit/0f50d0108c7ee8b081574a76816a428e30c6701a

Thanks for revert.

Do we have build bot so I can watch on the next attempt?

Thanks, I see a couple of URLs in https://github.com/llvm/llvm-project/commit/edb211cb78317ad73aa4bd2d3df75194b7f23a72

[vitalybuka]

I guess it was the followup patch edb211cb78317ad73aa4bd2d3df75194b7f23a72. It's re-landed (with fix) and passed both bots.

I will try to reland this one. Don't hesitate to revert if it break stuff.

compiler-rt/CMakeLists.txt

if(ANDROID)
   set(COMPILER_RT_HAS_LLD TRUE)
   set(COMPILER_RT_TEST_USE_LLD TRUE)
   append_list_if(COMPILER_RT_HAS_FUSE_LD_LLD_FLAG -fuse-ld=lld SANITIZER_COMMON_LINK_FLAGS)
   append_list_if(COMPILER_RT_HAS_LLD -fuse-ld=lld COMPILER_RT_UNITTEST_LINK_FLAGS)
 endif()
 pythonize_bool(COMPILER_RT_HAS_LLD)
 pythonize_bool(COMPILER_RT_TEST_USE_LLD)
 
+option(COMPILER_RT_ENABLE_INTERNAL_SYMBOLIZER "Build Compiler RT linked with in LLVM symbolizer" OFF)
+mark_as_advanced(COMPILER_RT_ENABLE_INTERNAL_SYMBOLIZER)
+
 add_subdirectory(lib)
 
 if(COMPILER_RT_INCLUDE_TESTS)
   add_subdirectory(unittests)
   add_subdirectory(test)
   # Don't build llvm-lit for runtimes-build, it will clean up map_config.
   if (COMPILER_RT_STANDALONE_BUILD AND NOT LLVM_RUNTIMES_BUILD)
     # If we have a valid source tree, generate llvm-lit into the bin directory.

compiler-rt/lib/sanitizer_common/CMakeLists.txt

 endif()
 
 
 foreach(arch ${SANITIZER_COMMON_SUPPORTED_ARCH})
   # Library implementing InternalSymbolizer. Empty by default.
   add_library(RTSanitizerCommonSymbolizerInternal.${arch}
               OBJECT IMPORTED GLOBAL)
 endforeach()
+
+if (COMPILER_RT_ENABLE_INTERNAL_SYMBOLIZER)
+  add_subdirectory(symbolizer)
+endif()

compiler-rt/lib/sanitizer_common/symbolizer/CMakeLists.txt

+foreach(arch ${SANITIZER_COMMON_SUPPORTED_ARCH})
+  get_target_flags_for_arch(${arch} TARGET_CFLAGS)
+
+  set(RTSanitizerCommonSymbolizerInternalDir
+      "${CMAKE_CURRENT_BINARY_DIR}/RTSanitizerCommonSymbolizerInternal.${arch}")
+  add_custom_command(OUTPUT ${RTSanitizerCommonSymbolizerInternalDir}
+                     COMMAND ${CMAKE_COMMAND} -E make_directory ${RTSanitizerCommonSymbolizerInternalDir})
+
+  add_custom_command(OUTPUT RTSanitizerCommonSymbolizerInternal.${arch}.o
+                     DEPENDS ${RTSanitizerCommonSymbolizerInternalDir} 
+                             clang lld llvm-tblgen opt llvm-ar llvm-link llvm-ranlib llvm-symbolizer
+                             sanitizer_wrappers.cpp
+                             sanitizer_symbolize.cpp
+                             scripts/build_symbolizer.sh
+                     WORKING_DIRECTORY ${RTSanitizerCommonSymbolizerInternalDir}
+                     COMMAND FLAGS=${TARGET_CFLAGS}
+                             CLANG=${LLVM_RUNTIME_OUTPUT_INTDIR}/clang
+                             ${CMAKE_CURRENT_SOURCE_DIR}/scripts/build_symbolizer.sh
+                             ${CMAKE_CURRENT_BINARY_DIR}/RTSanitizerCommonSymbolizerInternal.${arch}.o
+                     USES_TERMINAL)
+
+  add_custom_target(RTSanitizerCommonSymbolizerInternalObj.${arch}
+                    DEPENDS RTSanitizerCommonSymbolizerInternal.${arch}.o)
+
+  set_property(TARGET RTSanitizerCommonSymbolizerInternal.${arch}
+               PROPERTY IMPORTED_OBJECTS ${CMAKE_CURRENT_BINARY_DIR}/RTSanitizerCommonSymbolizerInternal.${arch}.o)
+endforeach()

compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh

 #!/usr/bin/env bash
 #
 # Run as: CLANG=bin/clang build_symbolizer.sh out.o
 # zlib can be downloaded from http://www.zlib.net.
 #
-# Script compiles self-contained object file with symbolization code and injects
-# it into the given set of runtime libraries. Script updates only libraries
-# which has unresolved __sanitizer_symbolize_* symbols and matches architecture.
-# Object file is be compiled from LLVM sources with dependencies like libc++ and
-# zlib. Then it internalizes symbols in the file, so that it can be linked
-# into arbitrary programs, avoiding conflicts with the program own symbols and
-# avoiding dependencies on any program symbols. The only acceptable dependencies
-# are libc and __sanitizer::internal_* from sanitizer runtime.
+# Script compiles self-contained object file with symbolization code.
 #
 # Symbols exported by the object file will be used by Sanitizer runtime
 # libraries to symbolize code/data in-process.
 #
-# The script will modify the output directory which is given as the first
-# argument to the script.
-#
 # FIXME: We should really be using a simpler approach to building this object
 # file, and it should be available as a regular cmake rule. Conceptually, we
 # want to be doing "ld -r" followed by "objcopy -G" to create a relocatable
 # object file with only our entry points exposed. However, this does not work at
-# present, see PR30750.
+# present, see https://github.com/llvm/llvm-project/issues/30098.
 
 set -x
 set -e
 set -u
 
 SCRIPT_DIR=$(cd "$(dirname "$0")" && pwd)
 SRC_DIR=$(readlink -f $SCRIPT_DIR/..)
-TARGE_DIR=$(readlink -f $1)
+OUTPUT=$(readlink -f $1)
 COMPILER_RT_SRC=$(readlink -f ${SCRIPT_DIR}/../../../..)
 LLVM_SRC=${LLVM_SRC:-${COMPILER_RT_SRC}/../llvm}
 LLVM_SRC=$(readlink -f $LLVM_SRC)
 
 CLANG="${CLANG:-`which clang`}"
 CLANG_DIR=$(readlink -f $(dirname "$CLANG"))
 
 CC=$CLANG_DIR/clang

 $OPT -passes=internalize -internalize-public-api-list=${SYMBOLIZER_API_LIST} all.bc -o opt.bc
 $CC $FLAGS -fno-lto -c opt.bc -o symbolizer.o
 
 echo "Checking undefined symbols..."
 nm -f posix -g symbolizer.o | cut -f 1,2 -d \  | LC_COLLATE=C sort -u > undefined.new
 (diff -u $SCRIPT_DIR/global_symbols.txt undefined.new | grep -E "^\+[^+]") && \
   (echo "Failed: unexpected symbols"; exit 1)
 
-arch() {
-  objdump -f $1 | grep -m1 -Po "(?<=file format ).*$"
-}
-
-SYMBOLIZER_FORMAT=$(arch symbolizer.o)
-echo "Injecting $SYMBOLIZER_FORMAT symbolizer..."
-for A in $TARGE_DIR/libclang_rt.*san*.a; do
-  A_FORMAT=$(arch $A)
-  if [[ "$A_FORMAT" != "$SYMBOLIZER_FORMAT" ]] ; then
-    continue
-  fi
-  (nm -u $A 2>/dev/null | grep -E "__sanitizer_symbolize_code" >/dev/null) || continue
-  echo "$A"
-  $AR rcs $A symbolizer.o
-done
+cp -f symbolizer.o $OUTPUT
 
 echo "Success!"