There is no pattern for ADCX/ADOX and they are never selected during
ISEL. So we remove the cases in some MIR optimizations in this patch.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/X86/X86InstrArithmetic.td | ||
---|---|---|
1377 ↗ | (On Diff #549389) | Why delete the predcate? |
llvm/lib/Target/X86/X86InstrArithmetic.td | ||
---|---|---|
1377 ↗ | (On Diff #549389) | Except assembler predicate like In64BitMode, a predicate only has effect when the pattern is not empty. |
llvm/lib/Target/X86/X86InstrArithmetic.td | ||
---|---|---|
1377 ↗ | (On Diff #549389) | I thought it could be used by https://reviews.llvm.org/D148516 that can use it to filter illegal instructions from llvm-exegesis testing. But I guess that uses the AssemblerPredicate so only filters In64BitMode. That seems kind of broken for its intended usage. |
llvm/lib/Target/X86/X86InstrArithmetic.td | ||
---|---|---|
1377 ↗ | (On Diff #549389) | I see. It seems that you prefer to keep the predicate. Let me revert the change in this file. |