This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Clear BreakPhiNodesCache in-between functions
ClosedPublic

Authored by Pierre-vh on Aug 11 2023, 6:20 AM.

Details

Summary

Otherwise stale pointers pollute the cache and
when a dead PHI's memory is reused for another PHI, we can get a false positive hit in the cache.

Diff Detail

Event Timeline

Pierre-vh created this revision.Aug 11 2023, 6:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2023, 6:20 AM
Pierre-vh requested review of this revision.Aug 11 2023, 6:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2023, 6:20 AM
arsenm accepted this revision.Aug 11 2023, 6:22 AM
arsenm added inline comments.
llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
322

Probably should do this on the exit. OldPM at least had a dedicated callbck for this

This revision is now accepted and ready to land.Aug 11 2023, 6:22 AM
This revision was landed with ongoing or failed builds.Aug 11 2023, 6:23 AM
This revision was automatically updated to reflect the committed changes.