This is an archive of the discontinued LLVM Phabricator instance.

[[llvm][AMDGPU][NFC]: Robustify mem intrinsic test
AbandonedPublic

Authored by urnathan on Aug 10 2023, 2:54 PM.

Details

Reviewers
arsenm
Summary

This test captures branch labels and uses them in phi matchers (or vice versa), but it doesn't actually capture or check the label definitions themselves. The difference is that the latter doesn't have a leading '%', which the former has and is captured. Thus the test is a little brittle. This redoes the label matching to also match the label definitions. I.e. the '%' is no longer part of the capture, and must be provided at the use point too.

Discovered when a patch set I'm working on disturbed the label numbering here.

Matt, I think you authored this test?

Diff Detail

Event Timeline

urnathan created this revision.Aug 10 2023, 2:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 2:54 PM
urnathan requested review of this revision.Aug 10 2023, 2:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 2:54 PM

These are generated checks, but you're manually fixing them?

urnathan abandoned this revision.Aug 13 2023, 2:56 PM