This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Move header_information.py up from tests, and remove non-existent headers
ClosedPublic

Authored by iana on Aug 10 2023, 11:23 AM.

Details

Summary

I need to use header_information.py in a generator script that isn't for tests in an upcoming change. Move it up a level so that it's in utils/libcxx instead of utils/libcxx/tests.
Also there are no such headers as experimental/algorithm and experimental/functional, remove them from header_information.py.

Diff Detail

Event Timeline

iana created this revision.Aug 10 2023, 11:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 11:23 AM
iana requested review of this revision.Aug 10 2023, 11:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 11:23 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision.Aug 11 2023, 9:07 AM

LGTM but one comment!

libcxx/utils/libcxx/header_information.py
18

The CI is green, can you commit this line and the next line in a separate commit, just to keep the history clean. No need for a new review.

This revision is now accepted and ready to land.Aug 11 2023, 9:07 AM
iana marked an inline comment as done.Aug 11 2023, 12:36 PM
iana added inline comments.
libcxx/utils/libcxx/header_information.py
18

👍

This revision was landed with ongoing or failed builds.Aug 11 2023, 12:45 PM
This revision was automatically updated to reflect the committed changes.
iana marked an inline comment as done.