This is an archive of the discontinued LLVM Phabricator instance.

Differential D157639

[libc++] Move header_information.py up from tests, and remove non-existent headers
ClosedPublic

Authored by iana on Aug 10 2023, 11:23 AM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rG1aee2434ce4c: [libc++] Move header_information.py up from tests
rGee5e8e6dcbbf: [libc++] Remove non-existent headers from header_information.py
Summary

I need to use header_information.py in a generator script that isn't for tests in an upcoming change. Move it up a level so that it's in utils/libcxx instead of utils/libcxx/tests.
Also there are no such headers as experimental/algorithm and experimental/functional, remove them from header_information.py.

Diff Detail

Event Timeline

iana created this revision.Aug 10 2023, 11:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 11:23 AM
Herald added subscribers: ributzka, arichardson. · View Herald Transcript
iana requested review of this revision.Aug 10 2023, 11:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 11:23 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
iana mentioned this in D157364: [libc++][Modules] Generate the __std_clang_module header.Aug 10 2023, 11:24 AM
iana added a child revision: D157364: [libc++][Modules] Generate the __std_clang_module header.Aug 10 2023, 11:49 AM
Harbormaster completed remote builds in B251749: Diff 549121.Aug 10 2023, 4:28 PM
Mordante accepted this revision.Aug 11 2023, 9:07 AM

LGTM but one comment!

libcxx/utils/libcxx/test/header_information.py
18

The CI is green, can you commit this line and the next line in a separate commit, just to keep the history clean. No need for a new review.

This revision is now accepted and ready to land.Aug 11 2023, 9:07 AM
iana marked an inline comment as done.Aug 11 2023, 12:36 PM
iana added inline comments.
libcxx/utils/libcxx/test/header_information.py
18

👍

This revision was landed with ongoing or failed builds.Aug 11 2023, 12:45 PM
Closed by commit rGee5e8e6dcbbf: [libc++] Remove non-existent headers from header_information.py (authored by iana). · Explain Why
This revision was automatically updated to reflect the committed changes.
iana marked an inline comment as done.
iana added a commit: rGee5e8e6dcbbf: [libc++] Remove non-existent headers from header_information.py.
iana added a commit: rG1aee2434ce4c: [libc++] Move header_information.py up from tests.

Revision Contents

PathSize
libcxx/
utils/
libcxx/
test/
2 lines

Diff 549496

libcxx/utils/libcxx/test/header_information.py

Show All 9 Lines
lit_header_restrictions = { lit_header_restrictions = {
"barrier": "// UNSUPPORTED: no-threads, c++03, c++11, c++14, c++17", "barrier": "// UNSUPPORTED: no-threads, c++03, c++11, c++14, c++17",
"clocale": "// UNSUPPORTED: no-localization", "clocale": "// UNSUPPORTED: no-localization",
"codecvt": "// UNSUPPORTED: no-localization", "codecvt": "// UNSUPPORTED: no-localization",
"coroutine": "// UNSUPPORTED: c++03, c++11, c++14, c++17", "coroutine": "// UNSUPPORTED: c++03, c++11, c++14, c++17",
"cwchar": "// UNSUPPORTED: no-wide-characters", "cwchar": "// UNSUPPORTED: no-wide-characters",
"cwctype": "// UNSUPPORTED: no-wide-characters", "cwctype": "// UNSUPPORTED: no-wide-characters",
"experimental/algorithm": "// UNSUPPORTED: c++03",
MordanteUnsubmitted
Done
ReplyInline Actions

The CI is green, can you commit this line and the next line in a separate commit, just to keep the history clean. No need for a new review.

Mordante: The CI is green, can you commit this line and the next line in a separate commit, just to keep…
ianaAuthorUnsubmitted
Done
ReplyInline Actions

👍

iana: 👍
"experimental/deque": "// UNSUPPORTED: c++03", "experimental/deque": "// UNSUPPORTED: c++03",
"experimental/forward_list": "// UNSUPPORTED: c++03", "experimental/forward_list": "// UNSUPPORTED: c++03",
"experimental/functional": "// UNSUPPORTED: c++03",
"experimental/iterator": "// UNSUPPORTED: c++03", "experimental/iterator": "// UNSUPPORTED: c++03",
"experimental/list": "// UNSUPPORTED: c++03", "experimental/list": "// UNSUPPORTED: c++03",
"experimental/map": "// UNSUPPORTED: c++03", "experimental/map": "// UNSUPPORTED: c++03",
"experimental/memory_resource": "// UNSUPPORTED: c++03", "experimental/memory_resource": "// UNSUPPORTED: c++03",
"experimental/propagate_const": "// UNSUPPORTED: c++03", "experimental/propagate_const": "// UNSUPPORTED: c++03",
"experimental/regex": "// UNSUPPORTED: no-localization, c++03", "experimental/regex": "// UNSUPPORTED: no-localization, c++03",
"experimental/set": "// UNSUPPORTED: c++03", "experimental/set": "// UNSUPPORTED: c++03",
"experimental/simd": "// UNSUPPORTED: c++03", "experimental/simd": "// UNSUPPORTED: c++03",
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines