This is an archive of the discontinued LLVM Phabricator instance.

[Coroutines][NFC] Only look for Alloca or Load when finding dbg.declare for temp spills
ClosedPublic

Authored by weiwang on Aug 8 2023, 10:54 AM.

Details

Summary

We only look for Alloca or Load in this case, so making it explicit.

Diff Detail

Event Timeline

weiwang created this revision.Aug 8 2023, 10:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 10:54 AM
weiwang requested review of this revision.Aug 8 2023, 10:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 10:54 AM
weiwang edited the summary of this revision. (Show Details)Aug 8 2023, 10:58 AM
weiwang added a reviewer: ChuanqiXu.
MatzeB accepted this revision.Aug 8 2023, 1:10 PM
MatzeB added a subscriber: MatzeB.

LGTM

llvm/lib/Transforms/Coroutines/CoroFrame.cpp
1868
This revision is now accepted and ready to land.Aug 8 2023, 1:10 PM
ChuanqiXu accepted this revision.Aug 8 2023, 6:30 PM

LGTM. Thanks.

llvm/lib/Transforms/Coroutines/CoroFrame.cpp
1868

nit

weiwang retitled this revision from [Coroutines][NFC]Only look for Alloca or Load when finding dbg.declare for temp spills to [Coroutines][NFC] Only look for Alloca or Load when finding dbg.declare for temp spills.Aug 8 2023, 11:44 PM
weiwang updated this revision to Diff 548485.Aug 9 2023, 12:08 AM
weiwang marked an inline comment as done.
weiwang edited the summary of this revision. (Show Details)

Apply comment

This revision was landed with ongoing or failed builds.Aug 9 2023, 12:20 AM
This revision was automatically updated to reflect the committed changes.