Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[Coroutines][NFC] Only look for Alloca or Load when finding dbg.declare for temp spills
ClosedPublic
Actions

Authored by weiwang on Aug 8 2023, 10:54 AM.

Details

Reviewers

ChuanqiXu
MatzeB

Commits

rGf55e57ca0c43: [Coroutines][NFC] Only look for Alloca or Load when finding dbg.declare for…

Summary

We only look for Alloca or Load in this case, so making it explicit.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

weiwang created this revision.Aug 8 2023, 10:54 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 10:54 AM

Herald added subscribers: ChuanqiXu, hoy, wenlei, hiraditya. · View Herald Transcript

weiwang requested review of this revision.Aug 8 2023, 10:54 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 10:54 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

weiwang edited the summary of this revision. (Show Details)Aug 8 2023, 10:58 AM

weiwang added a reviewer: ChuanqiXu.

LGTM

llvm/lib/Transforms/Coroutines/CoroFrame.cpp
1868

This revision is now accepted and ready to land.Aug 8 2023, 1:10 PM

Harbormaster completed remote builds in B251154: Diff 548284.Aug 8 2023, 3:30 PM

LGTM. Thanks.

llvm/lib/Transforms/Coroutines/CoroFrame.cpp
1868	nit

weiwang retitled this revision from [Coroutines][NFC]Only look for Alloca or Load when finding dbg.declare for temp spills to [Coroutines][NFC] Only look for Alloca or Load when finding dbg.declare for temp spills.Aug 8 2023, 11:44 PM

Apply comment

This revision was landed with ongoing or failed builds.Aug 9 2023, 12:20 AM

Closed by commit rGf55e57ca0c43: [Coroutines][NFC] Only look for Alloca or Load when finding dbg.declare for… (authored by weiwang). · Explain Why

This revision was automatically updated to reflect the committed changes.

weiwang added a commit: rGf55e57ca0c43: [Coroutines][NFC] Only look for Alloca or Load when finding dbg.declare for….

Harbormaster completed remote builds in B251298: Diff 548485.Aug 9 2023, 2:36 AM

weiwang mentioned this in D146543: [Coroutines] Look for dbg.declare for temp spills.Oct 25 2023, 4:06 PM

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Transforms/

Coroutines/

CoroFrame.cpp

2 lines

Diff 548489

View Options

llvm/lib/Transforms/Coroutines/CoroFrame.cpp