This is an archive of the discontinued LLVM Phabricator instance.

Differential D157260

[X86][NFC]Remove dead code in IfConversion.cpp
ClosedPublic

Authored by XinWang10 on Aug 7 2023, 1:42 AM.

Details

Reviewers
skan
pengfei
Commits
rGf4a6038e8065: [X86][NFC]Remove dead code in IfConversion.cpp
Summary

In line 544, if we go in to isFalse, then the Kind could be ICTriangleFalse and isRev must be False, so we never go into the true branch in line 545, better to remove it.

Diff Detail

Event Timeline

XinWang10 created this revision.Aug 7 2023, 1:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2023, 1:42 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
XinWang10 requested review of this revision.Aug 7 2023, 1:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2023, 1:42 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
XinWang10 edited the summary of this revision. (Show Details)Aug 7 2023, 1:44 AM
XinWang10 added reviewers: skan, pengfei.
Harbormaster completed remote builds in B250693: Diff 547672.Aug 7 2023, 2:16 AM
skan accepted this revision.Aug 7 2023, 6:39 PM

LGTM

This revision is now accepted and ready to land.Aug 7 2023, 6:39 PM
pengfei accepted this revision.Aug 7 2023, 7:05 PM
pengfei added inline comments.
llvm/lib/CodeGen/IfConversion.cpp
543–549

How about:

XinWang10 updated this revision to Diff 548037.Aug 7 2023, 7:30 PM
  • resolve comment
XinWang10 marked an inline comment as done.Aug 7 2023, 7:31 PM
Harbormaster completed remote builds in B250972: Diff 548037.Aug 7 2023, 10:06 PM
Closed by commit rGf4a6038e8065: [X86][NFC]Remove dead code in IfConversion.cpp (authored by XinWang10, committed by xin10.wang <wangxin8@scsel-icx-03.sc.intel.com>). · Explain WhyAug 7 2023, 11:50 PM
This revision was automatically updated to reflect the committed changes.
xin10.wang <wangxin8@scsel-icx-03.sc.intel.com> added a commit: rGf4a6038e8065: [X86][NFC]Remove dead code in IfConversion.cpp.

Revision Contents

PathSize
llvm/
lib/
CodeGen/
13 lines

Diff 548037

llvm/lib/CodeGen/IfConversion.cpp

Show First 20 Lines • Show All 534 Lines • ▼ Show 20 Lines while (!Tokens.empty()) {
LLVM_DEBUG(dbgs() << " false"); LLVM_DEBUG(dbgs() << " false");
if (isRev) if (isRev)
LLVM_DEBUG(dbgs() << " rev"); LLVM_DEBUG(dbgs() << " rev");
LLVM_DEBUG(dbgs() << "): " << printMBBReference(*BBI.BB) LLVM_DEBUG(dbgs() << "): " << printMBBReference(*BBI.BB)
<< " (T:" << BBI.TrueBB->getNumber() << " (T:" << BBI.TrueBB->getNumber()
<< ",F:" << BBI.FalseBB->getNumber() << ") "); << ",F:" << BBI.FalseBB->getNumber() << ") ");
RetVal = IfConvertTriangle(BBI, Kind); RetVal = IfConvertTriangle(BBI, Kind);
LLVM_DEBUG(dbgs() << (RetVal ? "succeeded!" : "failed!") << "\n"); LLVM_DEBUG(dbgs() << (RetVal ? "succeeded!" : "failed!") << "\n");
if (RetVal) { if (RetVal) {
if (isFalse) { if (isFalse)
if (isRev) ++NumTriangleFRev; ++NumTriangleFalse;
else ++NumTriangleFalse; else if (isRev)
} else { ++NumTriangleRev;
if (isRev) ++NumTriangleRev; else
else ++NumTriangle; ++NumTriangle;
pengfeiUnsubmitted
Done
ReplyInline Actions
if (RetVal) {
- if (isFalse) {
+ if (isFalse)
++NumTriangleFalse;
- } else {
- if (isRev) ++NumTriangleRev;
- else ++NumTriangle;
- }
+ else if (isRev)
+ ++NumTriangleRev;
+ else
+ ++NumTriangle;
}
break;

How about:

pengfei: How about:
}
} }
break; break;
} }
case ICDiamond: case ICDiamond:
if (DisableDiamond) break; if (DisableDiamond) break;
LLVM_DEBUG(dbgs() << "Ifcvt (Diamond): " << printMBBReference(*BBI.BB) LLVM_DEBUG(dbgs() << "Ifcvt (Diamond): " << printMBBReference(*BBI.BB)
<< " (T:" << BBI.TrueBB->getNumber() << " (T:" << BBI.TrueBB->getNumber()
<< ",F:" << BBI.FalseBB->getNumber() << ") "); << ",F:" << BBI.FalseBB->getNumber() << ") ");
▲ Show 20 Lines • Show All 1,802 Lines • Show Last 20 Lines