In line 544, if we go in to isFalse, then the Kind could be ICTriangleFalse and isRev must be False, so we never go into the true branch in line 545, better to remove it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Paths
| Differential D157260
[X86][NFC]Remove dead code in IfConversion.cpp ClosedPublic Authored by XinWang10 on Aug 7 2023, 1:42 AM.
Details
Summary In line 544, if we go in to isFalse, then the Kind could be ICTriangleFalse and isRev must be False, so we never go into the true branch in line 545, better to remove it.
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Aug 7 2023, 6:39 PM Closed by commit rGf4a6038e8065: [X86][NFC]Remove dead code in IfConversion.cpp (authored by XinWang10, committed by xin10.wang <wangxin8@scsel-icx-03.sc.intel.com>). · Explain WhyAug 7 2023, 11:50 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 547672 llvm/lib/CodeGen/IfConversion.cpp
|
How about: