[clangd] Dont assert on specific uris for diagnostics docs

[kadircet]

Summary

To enable customization of links in downstream projects without
breaking tests (and also ease of pointing at different links in the future).
Just check for existence instead.

clang-tools-extra/clangd/test/include-cleaner-batch-fix.test

 
 # Then, diagnostic from the main cpp file.
 #      CHECK:  "method": "textDocument/publishDiagnostics",
 # CHECK-NEXT:  "params": {
 # CHECK-NEXT:     "diagnostics": [
 # CHECK-NEXT:       {
 # CHECK-NEXT:         "code": "missing-includes",
 # CHECK-NEXT:         "codeDescription": {
-# CHECK-NEXT:           "href": "https://clangd.llvm.org/guides/include-cleaner"
+# CHECK-NEXT:           "href": "{{.*}}"
 # CHECK-NEXT:         },
 # CHECK-NEXT:         "message": "No header providing \"Foo\" is directly included (fixes available)",
 # CHECK-NEXT:         "range": {
 # CHECK-NEXT:           "end": {
 # CHECK-NEXT:             "character": 4,
 # CHECK-NEXT:             "line": 2
 # CHECK-NEXT:           },
 # CHECK-NEXT:           "start": {
 # CHECK-NEXT:             "character": 1,
 # CHECK-NEXT:             "line": 2
 # CHECK-NEXT:           }
 # CHECK-NEXT:         },
 # CHECK-NEXT:         "severity": 3,
 # CHECK-NEXT:         "source": "clangd"
 # CHECK-NEXT:       },
 # CHECK-NEXT:       {
 # CHECK-NEXT:         "code": "missing-includes",
 # CHECK-NEXT:         "codeDescription": {
-# CHECK-NEXT:           "href": "https://clangd.llvm.org/guides/include-cleaner"
+# CHECK-NEXT:           "href": "{{.*}}"
 # CHECK-NEXT:         },
 # CHECK-NEXT:         "message": "No header providing \"Bar\" is directly included (fixes available)",
 # CHECK-NEXT:         "range": {
 # CHECK-NEXT:           "end": {
 # CHECK-NEXT:             "character": 14,
 # CHECK-NEXT:             "line": 2
 # CHECK-NEXT:           },
 # CHECK-NEXT:           "start": {
 # CHECK-NEXT:             "character": 11,
 # CHECK-NEXT:             "line": 2
 # CHECK-NEXT:           }
 # CHECK-NEXT:         },
 # CHECK-NEXT:         "severity": 3,
 # CHECK-NEXT:         "source": "clangd"
 # CHECK-NEXT:       },
 # CHECK-NEXT:       {
 # CHECK-NEXT:         "code": "unused-includes",
 # CHECK-NEXT:         "codeDescription": {
-# CHECK-NEXT:           "href": "https://clangd.llvm.org/guides/include-cleaner"
+# CHECK-NEXT:           "href": "{{.*}}"
 # CHECK-NEXT:         },
 # CHECK-NEXT:         "message": "Included header all1.h is not used directly (fixes available)",
 # CHECK-NEXT:         "range": {
 # CHECK-NEXT:           "end": {
 # CHECK-NEXT:             "character": 17,
 # CHECK-NEXT:             "line": 0
 # CHECK-NEXT:           },
 # CHECK-NEXT:           "start": {
 # CHECK-NEXT:             "character": 0,
 # CHECK-NEXT:             "line": 0
 # CHECK-NEXT:           }
 # CHECK-NEXT:         },
 # CHECK-NEXT:         "severity": 2,
 # CHECK-NEXT:         "source": "clangd",
 # CHECK-NEXT:         "tags": [
 # CHECK-NEXT:           1
 # CHECK-NEXT:         ]
 # CHECK-NEXT:       },
 # CHECK-NEXT:       {
 # CHECK-NEXT:         "code": "unused-includes",
 # CHECK-NEXT:         "codeDescription": {
-# CHECK-NEXT:           "href": "https://clangd.llvm.org/guides/include-cleaner"
+# CHECK-NEXT:           "href": "{{.*}}"
 # CHECK-NEXT:         },
 # CHECK-NEXT:         "message": "Included header all2.h is not used directly (fixes available)",
 # CHECK-NEXT:         "range": {
 # CHECK-NEXT:           "end": {
 # CHECK-NEXT:             "character": 17,
 # CHECK-NEXT:             "line": 1
 # CHECK-NEXT:           },
 # CHECK-NEXT:           "start": {

clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

 #include "clang/Basic/DiagnosticSema.h"
 #include "clang/Basic/LLVM.h"
 #include "clang/Basic/Specifiers.h"
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/Support/JSON.h"
 #include "llvm/Support/ScopedPrinter.h"
 #include "llvm/Support/TargetSelect.h"
+#include "llvm/Testing/Support/SupportHelpers.h"
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
 #include <cstddef>
 #include <memory>
 #include <optional>
 #include <string>
 #include <utility>
 #include <vector>
]]
   EXPECT_THAT(
       AST.getDiagnostics(),
       Contains(AllOf(
           Diag(Test.range("diag"),
                "included header unused.h is not used directly"),
           withTag(DiagnosticTag::Unnecessary), diagSource(Diag::Clangd),
           withFix(Fix(Test.range("fix"), "", "remove #include directive")))));
   auto &Diag = AST.getDiagnostics().front();
-  EXPECT_EQ(getDiagnosticDocURI(Diag.Source, Diag.ID, Diag.Name),
-            std::string("https://clangd.llvm.org/guides/include-cleaner"));
+  EXPECT_THAT(getDiagnosticDocURI(Diag.Source, Diag.ID, Diag.Name),
+              llvm::ValueIs(Not(IsEmpty())));
   Cfg.Diagnostics.SuppressAll = true;
   WithContextValue SuppressAllWithCfg(Config::Key, std::move(Cfg));
   EXPECT_THAT(TU.build().getDiagnostics(), IsEmpty());
   Cfg.Diagnostics.SuppressAll = false;
   Cfg.Diagnostics.Suppress = {"unused-includes"};
   WithContextValue SuppressFilterWithCfg(Config::Key, std::move(Cfg));
   EXPECT_THAT(TU.build().getDiagnostics(), IsEmpty());
 }