This is an archive of the discontinued LLVM Phabricator instance.

[clang][ExtractAPI] Add support for C++ classes with fix
ClosedPublic

Authored by evelez7 on Aug 3 2023, 8:05 AM.

Details

Summary

Reintroduce D153557 with fix for use-after-free from f4de606ef271 and minor changes.

Diff Detail

Event Timeline

evelez7 created this revision.Aug 3 2023, 8:05 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ChuanqiXu. · View Herald Transcript
evelez7 requested review of this revision.Aug 3 2023, 8:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2023, 8:05 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
evelez7 added inline comments.Aug 3 2023, 8:12 AM
clang/lib/ExtractAPI/DeclarationFragments.cpp
611

Minor change is here. Since Name is now an std::string, a cast to Method's DeclContext is no longer needed to bypass the simple identifier assertion from getName for StringRefs.

evelez7 updated this revision to Diff 546963.Aug 3 2023, 11:42 AM

Remove Parser include and remove bazel dependency introduced in 926f85db98aa.

This include should not be necessary.

dang accepted this revision.Aug 4 2023, 2:05 AM

LGTM

This revision is now accepted and ready to land.Aug 4 2023, 2:05 AM
This revision was automatically updated to reflect the committed changes.