Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

evelez7 (Erick Velez)
User

Projects

User does not belong to any projects.

User Details

User Since
May 23 2023, 10:56 AM (18 w, 6 d)

Recent Activity

Aug 22 2023

evelez7 committed rGe81744563a53: [clang][ExtractAPI] Fix bool spelling coming from the macro definition. (authored by evelez7).
[clang][ExtractAPI] Fix bool spelling coming from the macro definition.
Aug 22 2023, 3:00 PM · Restricted Project, Restricted Project
evelez7 closed D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition..
Aug 22 2023, 3:00 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition..

Use clang instead of clang_cc1 like other C tests.

Aug 22 2023, 2:13 PM · Restricted Project, Restricted Project
evelez7 committed rG08f034f952fa: [clang][ExtractAPI] Add support for namespaces (authored by evelez7).
[clang][ExtractAPI] Add support for namespaces
Aug 22 2023, 9:57 AM · Restricted Project, Restricted Project
evelez7 closed D158239: [clang][ExtractAPI] Add support for namespaces.
Aug 22 2023, 9:57 AM · Restricted Project, Restricted Project

Aug 21 2023

evelez7 requested review of D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition..
Aug 21 2023, 6:43 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D158239: [clang][ExtractAPI] Add support for namespaces.

Move DetermineParentDecl to determineParentRecord in APIVisitor as a private method.

Aug 21 2023, 3:31 PM · Restricted Project, Restricted Project
evelez7 added a comment to D158031: [clang][ExtractAPI] Refactor C++ method and field visitation.

Did this change not affect ordering of the symbols in the generated JSON? Looks pretty good to me otherwise!

Aug 21 2023, 10:39 AM · Restricted Project, Restricted Project
evelez7 committed rG3bb485530869: [clang][ExtractAPI] Refactor C++ method and field visitation (authored by evelez7).
[clang][ExtractAPI] Refactor C++ method and field visitation
Aug 21 2023, 10:38 AM · Restricted Project, Restricted Project
evelez7 closed D158031: [clang][ExtractAPI] Refactor C++ method and field visitation.
Aug 21 2023, 10:38 AM · Restricted Project, Restricted Project
evelez7 committed rG634b2fd2cac2: [clang][ExtractAPI] Add support for C++ member templates (authored by evelez7).
[clang][ExtractAPI] Add support for C++ member templates
Aug 21 2023, 10:18 AM · Restricted Project, Restricted Project
evelez7 closed D158029: [clang][ExtractAPI] Add support for C++ member templates.
Aug 21 2023, 10:18 AM · Restricted Project, Restricted Project
evelez7 committed rGd8e9c5d9cab5: [clang][ExtractAPI] Visit method templates with better scheme (authored by evelez7).
[clang][ExtractAPI] Visit method templates with better scheme
Aug 21 2023, 9:06 AM · Restricted Project, Restricted Project
evelez7 closed D158027: [clang][ExtractAPI] Visit method templates with better scheme.
Aug 21 2023, 9:06 AM · Restricted Project, Restricted Project

Aug 18 2023

evelez7 committed rG80b787e80329: [clang][ExtractAPI] Add support for C++ global function templates (authored by evelez7).
[clang][ExtractAPI] Add support for C++ global function templates
Aug 18 2023, 5:42 PM · Restricted Project, Restricted Project
evelez7 closed D157579: [clang][ExtractAPI] Add support for C++ global function templates.
Aug 18 2023, 5:42 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157579: [clang][ExtractAPI] Add support for C++ global function templates.

Formatting changes, keep GlobalFunction has templates together and revert extraneous formatting

Aug 18 2023, 2:33 PM · Restricted Project, Restricted Project
evelez7 committed rG8d8c8981cac0: [clang][ExtractAPI] Add support for C++ variable templates (authored by evelez7).
[clang][ExtractAPI] Add support for C++ variable templates
Aug 18 2023, 1:58 PM · Restricted Project, Restricted Project
evelez7 closed D157350: [clang][ExtractAPI] Add support for C++ variable templates.
Aug 18 2023, 1:58 PM · Restricted Project, Restricted Project
evelez7 committed rG7ba37f4e46a5: [clang][ExtractAPI] Add support for C++ class templates and concepts (authored by evelez7).
[clang][ExtractAPI] Add support for C++ class templates and concepts
Aug 18 2023, 1:41 PM · Restricted Project, Restricted Project
evelez7 closed D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.
Aug 18 2023, 1:41 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.

Fix formatting for introduced declarations in DeclarationFragments.h

Aug 18 2023, 11:55 AM · Restricted Project, Restricted Project
evelez7 updated the diff for D158239: [clang][ExtractAPI] Add support for namespaces.

Revert extraneous formatting in API.h

Aug 18 2023, 8:30 AM · Restricted Project, Restricted Project

Aug 17 2023

evelez7 added a comment to D158239: [clang][ExtractAPI] Add support for namespaces.

Note that this doesn't handle anonymous namespaces. Similar problems arise with anonymous classes/structs, being worked on.

Aug 17 2023, 5:49 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D158239: [clang][ExtractAPI] Add support for namespaces.

Remove unnecessary line break.

Aug 17 2023, 5:42 PM · Restricted Project, Restricted Project
evelez7 requested review of D158239: [clang][ExtractAPI] Add support for namespaces.
Aug 17 2023, 5:38 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D158031: [clang][ExtractAPI] Refactor C++ method and field visitation.

Fix passing Decl's template, introduced from parent updates

Aug 17 2023, 11:39 AM · Restricted Project, Restricted Project

Aug 16 2023

evelez7 updated the diff for D158029: [clang][ExtractAPI] Add support for C++ member templates.

Update to use the new Template class constructor instead of old getFragments.

Aug 16 2023, 7:12 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D158027: [clang][ExtractAPI] Visit method templates with better scheme.

Update Spec naming

Aug 16 2023, 6:42 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157350: [clang][ExtractAPI] Add support for C++ variable templates.

Forgot Spec instance in SerializerBase

Aug 16 2023, 6:30 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157579: [clang][ExtractAPI] Add support for C++ global function templates.

Update instances of Spec to Specialization

Aug 16 2023, 6:25 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.

Also rename traverseSpec* in SerializerBase.h

Aug 16 2023, 5:53 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157350: [clang][ExtractAPI] Add support for C++ variable templates.

Update all instances of Spec to Specialization

Aug 16 2023, 5:49 PM · Restricted Project, Restricted Project
evelez7 added a comment to D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.

We didn't handle inheriting from a template parameter, but now we do by serializing the relationship. The parameter does not produce a target USR so it falls back to its name.

Aug 16 2023, 4:47 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.

Address review feedback

Aug 16 2023, 4:45 PM · Restricted Project, Restricted Project

Aug 15 2023

evelez7 requested review of D158031: [clang][ExtractAPI] Refactor C++ method and field visitation.
Aug 15 2023, 3:53 PM · Restricted Project, Restricted Project
evelez7 requested review of D158029: [clang][ExtractAPI] Add support for C++ member templates.
Aug 15 2023, 3:19 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D158027: [clang][ExtractAPI] Visit method templates with better scheme.

Fix arbitrary include changes

Aug 15 2023, 3:10 PM · Restricted Project, Restricted Project
evelez7 requested review of D158027: [clang][ExtractAPI] Visit method templates with better scheme.
Aug 15 2023, 2:59 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157350: [clang][ExtractAPI] Add support for C++ variable templates.

Get rid of unnecessary function for checking if global var

Aug 15 2023, 2:43 PM · Restricted Project, Restricted Project

Aug 9 2023

evelez7 requested review of D157579: [clang][ExtractAPI] Add support for C++ global function templates.
Aug 9 2023, 8:47 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.

Fix template arg identification

Aug 9 2023, 8:34 PM · Restricted Project, Restricted Project

Aug 7 2023

evelez7 updated the diff for D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.

Add brackets for SerializerBase visit methods

Aug 7 2023, 8:11 PM · Restricted Project, Restricted Project
evelez7 requested review of D157350: [clang][ExtractAPI] Add support for C++ variable templates.
Aug 7 2023, 6:28 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.

Refactor template arg name deduction to get as string for FragmentKind::typeIdentifier

Aug 7 2023, 3:04 PM · Restricted Project, Restricted Project

Aug 4 2023

evelez7 updated the diff for D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.

Abstract the name deduction for generic template args to its own function. It's very helpful in other cases.

Aug 4 2023, 4:06 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.

Add documentation to template argument name deduction, add missing method declarations to visitor base

Aug 4 2023, 12:43 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.

Format DeclarationFragments.h, try to address buildbot fail on clang-format

Aug 4 2023, 9:59 AM · Restricted Project, Restricted Project
evelez7 committed rG75f55eb331e0: [clang][ExtractAPI] Add support for C++ classes with fix (authored by evelez7).
[clang][ExtractAPI] Add support for C++ classes with fix
Aug 4 2023, 7:32 AM · Restricted Project, Restricted Project
evelez7 closed D157007: [clang][ExtractAPI] Add support for C++ classes with fix.
Aug 4 2023, 7:31 AM · Restricted Project, Restricted Project
evelez7 requested review of D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts.
Aug 4 2023, 12:27 AM · Restricted Project, Restricted Project
evelez7 abandoned D157075: [clang][ExtractAPI] Add support for C++ class templates and concepts Depends on D157007.
Aug 4 2023, 12:20 AM · Restricted Project, Restricted Project
evelez7 requested review of D157075: [clang][ExtractAPI] Add support for C++ class templates and concepts Depends on D157007.
Aug 4 2023, 12:18 AM · Restricted Project, Restricted Project

Aug 3 2023

evelez7 updated the diff for D157007: [clang][ExtractAPI] Add support for C++ classes with fix.

Remove Parser include and remove bazel dependency introduced in 926f85db98aa.

Aug 3 2023, 11:42 AM · Restricted Project, Restricted Project
evelez7 added inline comments to D157007: [clang][ExtractAPI] Add support for C++ classes with fix.
Aug 3 2023, 8:12 AM · Restricted Project, Restricted Project
evelez7 requested review of D157007: [clang][ExtractAPI] Add support for C++ classes with fix.
Aug 3 2023, 8:05 AM · Restricted Project, Restricted Project
evelez7 closed D153557: [clang][ExtractAPI] Add support for C++ classes.
Aug 3 2023, 7:06 AM · Restricted Project, Restricted Project

Aug 2 2023

evelez7 updated the diff for D153557: [clang][ExtractAPI] Add support for C++ classes.

Reintroduce fix from f4de606ef271 and use clang frontend for C++ tests.

Aug 2 2023, 4:15 PM · Restricted Project, Restricted Project
evelez7 reopened D153557: [clang][ExtractAPI] Add support for C++ classes.
Aug 2 2023, 4:09 PM · Restricted Project, Restricted Project
evelez7 added a comment to D153557: [clang][ExtractAPI] Add support for C++ classes.

@haowei Thank you for letting me know! That patch does seem to fix it, unfortunately it didn't fail on my end. Thanks again.

Aug 2 2023, 3:39 PM · Restricted Project, Restricted Project
evelez7 added a reverting change for rG8b76b44e46ac: [clang][ExtractAPI] Add support for C++ classes: rG20f7cc0df3c1: Revert "[clang][ExtractAPI] Add support for C++ classes".
Aug 2 2023, 1:24 PM · Restricted Project, Restricted Project
evelez7 committed rG20f7cc0df3c1: Revert "[clang][ExtractAPI] Add support for C++ classes" (authored by evelez7).
Revert "[clang][ExtractAPI] Add support for C++ classes"
Aug 2 2023, 1:24 PM · Restricted Project, Restricted Project
evelez7 added a reverting change for D153557: [clang][ExtractAPI] Add support for C++ classes: rG20f7cc0df3c1: Revert "[clang][ExtractAPI] Add support for C++ classes".
Aug 2 2023, 1:24 PM · Restricted Project, Restricted Project
evelez7 added a comment to D153557: [clang][ExtractAPI] Add support for C++ classes.
Aug 2 2023, 12:54 PM · Restricted Project, Restricted Project
evelez7 committed rG8b76b44e46ac: [clang][ExtractAPI] Add support for C++ classes (authored by evelez7).
[clang][ExtractAPI] Add support for C++ classes
Aug 2 2023, 10:19 AM · Restricted Project, Restricted Project
evelez7 closed D153557: [clang][ExtractAPI] Add support for C++ classes.
Aug 2 2023, 10:19 AM · Restricted Project, Restricted Project

Aug 1 2023

evelez7 updated the diff for D153557: [clang][ExtractAPI] Add support for C++ classes.

Add test for overloaded operator.

Aug 1 2023, 10:36 PM · Restricted Project, Restricted Project
evelez7 added inline comments to D153557: [clang][ExtractAPI] Add support for C++ classes.
Aug 1 2023, 10:07 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D153557: [clang][ExtractAPI] Add support for C++ classes.

Address review feedback, add tests, and small refactors.

Aug 1 2023, 10:07 PM · Restricted Project, Restricted Project

Jul 31 2023

evelez7 committed rG422bcd10c48b: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON (authored by evelez7).
[clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON
Jul 31 2023, 11:29 PM · Restricted Project, Restricted Project
evelez7 closed D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON.
Jul 31 2023, 11:29 PM · Restricted Project, Restricted Project

Jun 30 2023

evelez7 updated the diff for D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON.

Move semicolon line below After fragment

Jun 30 2023, 7:45 AM · Restricted Project, Restricted Project

Jun 29 2023

evelez7 added a comment to D153557: [clang][ExtractAPI] Add support for C++ classes.

There aren't any variables or fields in the tests currently, waiting on D154038 because of no semicolons in their fragments.

Jun 29 2023, 5:58 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D153557: [clang][ExtractAPI] Add support for C++ classes.

Add C++ class tests, fix exception spec fragments

Jun 29 2023, 5:44 PM · Restricted Project, Restricted Project

Jun 28 2023

evelez7 added a comment to D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON.

These updated tests pass locally for me, not sure why the build test failed.

Jun 28 2023, 7:41 PM · Restricted Project, Restricted Project
evelez7 requested review of D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON.
Jun 28 2023, 7:28 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D153557: [clang][ExtractAPI] Add support for C++ classes.

Address some review feedback

Jun 28 2023, 4:14 PM · Restricted Project, Restricted Project

Jun 23 2023

evelez7 updated the diff for D153557: [clang][ExtractAPI] Add support for C++ classes.

Add conversion function and overloaded operator support

Jun 23 2023, 6:34 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D153557: [clang][ExtractAPI] Add support for C++ classes.

Fix duplicate visitation of CXXRecordDecls by overloading WalkUpFromCXXRecordDecl

Jun 23 2023, 1:18 PM · Restricted Project, Restricted Project

Jun 22 2023

evelez7 updated the diff for D153557: [clang][ExtractAPI] Add support for C++ classes.

Do not include return types for constructors/destructors

Jun 22 2023, 3:14 PM · Restricted Project, Restricted Project
evelez7 updated the diff for D153557: [clang][ExtractAPI] Add support for C++ classes.

Add access control serialization

Jun 22 2023, 2:42 PM · Restricted Project, Restricted Project
evelez7 requested review of D153557: [clang][ExtractAPI] Add support for C++ classes.
Jun 22 2023, 8:06 AM · Restricted Project, Restricted Project

May 26 2023

evelez7 updated the diff for D151477: [clang][ExtractAPI] Refactor serializer to the CRTP.

Address review feedback

May 26 2023, 11:52 AM · Restricted Project, Restricted Project

May 25 2023

evelez7 abandoned D151293: [clang][ExtractAPI] Refactor serializer to the CRTP.
May 25 2023, 12:50 PM · Restricted Project, Restricted Project
evelez7 requested review of D151477: [clang][ExtractAPI] Refactor serializer to the CRTP.
May 25 2023, 11:22 AM · Restricted Project, Restricted Project
evelez7 abandoned D151402: Address some review feedback.
May 25 2023, 11:09 AM · Restricted Project, Restricted Project
evelez7 updated the diff for D151293: [clang][ExtractAPI] Refactor serializer to the CRTP.

Really address review feedback

May 25 2023, 9:03 AM · Restricted Project, Restricted Project

May 24 2023

evelez7 updated the diff for D151293: [clang][ExtractAPI] Refactor serializer to the CRTP.

Address some review feedback

May 24 2023, 9:08 PM · Restricted Project, Restricted Project
evelez7 requested review of D151402: Address some review feedback.
May 24 2023, 8:34 PM · Restricted Project, Restricted Project

May 23 2023

evelez7 requested review of D151293: [clang][ExtractAPI] Refactor serializer to the CRTP.
May 23 2023, 10:47 PM · Restricted Project, Restricted Project