This is an archive of the discontinued LLVM Phabricator instance.

Differential D156913

[flang][openacc] Add lowering support for the link clause on OpenACC declare
ClosedPublic

Authored by clementval on Aug 2 2023, 9:44 AM.

Details

Reviewers
razvanlupusoru
vzakhari
Commits
rGb82c25937043: [flang][openacc] Add lowering support for the link clause on OpenACC declare
Summary

Lower link clause with data entry operation.

Diff Detail

Event Timeline

clementval created this revision.Aug 2 2023, 9:44 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 2 2023, 9:44 AM
Herald added subscribers: sunshaoce, mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Aug 2 2023, 9:44 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptAug 2 2023, 9:44 AM
Harbormaster completed remote builds in B249817: Diff 546519.Aug 2 2023, 9:45 AM
razvanlupusoru accepted this revision.Aug 2 2023, 3:11 PM

Seems OK to me!

This revision is now accepted and ready to land.Aug 2 2023, 3:11 PM
This revision was landed with ongoing or failed builds.Aug 3 2023, 10:23 AM
Closed by commit rGb82c25937043: [flang][openacc] Add lowering support for the link clause on OpenACC declare (authored by clementval). · Explain Why
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rGb82c25937043: [flang][openacc] Add lowering support for the link clause on OpenACC declare.

Revision Contents

PathSize
flang/
lib/
Lower/
6 lines
test/
Lower/
OpenACC/
16 lines

Diff 546934

flang/lib/Lower/OpenACC.cpp

Show First 20 Lines • Show All 2,459 Lines • ▼ Show 20 Lines if (const auto *copyClause =
dataClauseOperands.end()); dataClauseOperands.end());
} else if (const auto *devicePtrClause = } else if (const auto *devicePtrClause =
std::get_if<Fortran::parser::AccClause::Deviceptr>( std::get_if<Fortran::parser::AccClause::Deviceptr>(
&clause.u)) { &clause.u)) {
genDataOperandOperations<mlir::acc::DevicePtrOp>( genDataOperandOperations<mlir::acc::DevicePtrOp>(
devicePtrClause->v, converter, semanticsContext, stmtCtx, devicePtrClause->v, converter, semanticsContext, stmtCtx,
dataClauseOperands, mlir::acc::DataClause::acc_deviceptr, dataClauseOperands, mlir::acc::DataClause::acc_deviceptr,
/*structured=*/true); /*structured=*/true);
} else if (const auto *linkClause =
std::get_if<Fortran::parser::AccClause::Link>(&clause.u)) {
genDataOperandOperations<mlir::acc::DeclareLinkOp>(
linkClause->v, converter, semanticsContext, stmtCtx,
dataClauseOperands, mlir::acc::DataClause::acc_declare_link,
/*structured=*/true);
} else { } else {
mlir::Location clauseLocation = converter.genLocation(clause.source); mlir::Location clauseLocation = converter.genLocation(clause.source);
TODO(clauseLocation, "clause on declare directive"); TODO(clauseLocation, "clause on declare directive");
} }
} }
builder.create<mlir::acc::DeclareEnterOp>(loc, dataClauseOperands); builder.create<mlir::acc::DeclareEnterOp>(loc, dataClauseOperands);
if (!createEntryOperands.empty() || !copyEntryOperands.empty() || if (!createEntryOperands.empty() || !copyEntryOperands.empty() ||
▲ Show 20 Lines • Show All 148 Lines • Show Last 20 Lines

flang/test/Lower/OpenACC/acc-declare.f90

Show First 20 Lines • Show All 183 Lines • ▼ Show 20 Lines
! CHECK-LABEL: func.func @_QMacc_declarePacc_declare_deviceptr( ! CHECK-LABEL: func.func @_QMacc_declarePacc_declare_deviceptr(
! CHECK-SAME: %[[ARG0:.*]]: !fir.ref<!fir.array<100xi32>> {fir.bindc_name = "a"}) { ! CHECK-SAME: %[[ARG0:.*]]: !fir.ref<!fir.array<100xi32>> {fir.bindc_name = "a"}) {
! CHECK: %[[DEVICEPTR:.*]] = acc.deviceptr varPtr(%[[ARG0]] : !fir.ref<!fir.array<100xi32>>) bounds(%{{.*}}) -> !fir.ref<!fir.array<100xi32>> {name = "a"} ! CHECK: %[[DEVICEPTR:.*]] = acc.deviceptr varPtr(%[[ARG0]] : !fir.ref<!fir.array<100xi32>>) bounds(%{{.*}}) -> !fir.ref<!fir.array<100xi32>> {name = "a"}
! CHECK: acc.declare_enter dataOperands(%[[DEVICEPTR]] : !fir.ref<!fir.array<100xi32>>) ! CHECK: acc.declare_enter dataOperands(%[[DEVICEPTR]] : !fir.ref<!fir.array<100xi32>>)
! CHECK: %{{.*}}:2 = fir.do_loop %{{.*}} = %{{.*}} to %{{.*}} step %{{.*}} iter_args(%arg{{.*}} = %{{.*}}) -> (index, i32) ! CHECK: %{{.*}}:2 = fir.do_loop %{{.*}} = %{{.*}} to %{{.*}} step %{{.*}} iter_args(%arg{{.*}} = %{{.*}}) -> (index, i32)
! CHECK-NOT: acc.declare_exit ! CHECK-NOT: acc.declare_exit
subroutine acc_declare_link(a)
integer :: a(100), i
!$acc declare link(a)
do i = 1, 100
a(i) = i
end do
end subroutine
! CHECK-LABEL: func.func @_QMacc_declarePacc_declare_link(
! CHECK-SAME: %[[ARG0:.*]]: !fir.ref<!fir.array<100xi32>> {fir.bindc_name = "a"})
! CHECK: %[[LINK:.*]] = acc.declare_link varPtr(%[[ARG0]] : !fir.ref<!fir.array<100xi32>>) bounds(%{{.*}}) -> !fir.ref<!fir.array<100xi32>> {name = "a"}
! CHECK: acc.declare_enter dataOperands(%[[LINK]] : !fir.ref<!fir.array<100xi32>>)
! CHECK: %{{.*}}:2 = fir.do_loop %{{.*}} = %{{.*}} to %{{.*}} step %{{.*}} iter_args(%arg{{.*}} = %{{.*}}) -> (index, i32)
! CHECK-NOT: acc.declare_exit
end module end module