This is an archive of the discontinued LLVM Phabricator instance.

[X86] Special handle for v1i1 during ExtractBitFromMaskVector
ClosedPublic

Authored by pengfei on Aug 2 2023, 12:12 AM.

Diff Detail

Unit TestsFailed

Event Timeline

pengfei created this revision.Aug 2 2023, 12:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2023, 12:12 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
pengfei requested review of this revision.Aug 2 2023, 12:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2023, 12:12 AM
RKSimon added inline comments.Aug 2 2023, 3:23 AM
llvm/lib/Target/X86/X86ISelLowering.cpp
17659

Why not put this inside the (!IdxC) if-block above?

pengfei updated this revision to Diff 546469.Aug 2 2023, 7:41 AM
pengfei marked an inline comment as done.

Put into (!IdxC) if-block.

RKSimon accepted this revision.Aug 2 2023, 8:24 AM

LGTM - cheers

This revision is now accepted and ready to land.Aug 2 2023, 8:24 AM
This revision was landed with ongoing or failed builds.Aug 2 2023, 7:50 PM
This revision was automatically updated to reflect the committed changes.