This is an archive of the discontinued LLVM Phabricator instance.

Remove some noisy log messages from showing up in llvm-gsymutil output.
ClosedPublic

Authored by clayborg on Aug 1 2023, 3:56 PM.

Details

Summary

This patch removes two log messages that were causing noisy output:

  • when we have a zero sized symbol that gets removed in favor of something with a size or with debug info
  • when an inlined function's address range has the same high and low pc, don't emit an error message as this is a common technique to indicate a function has been stripped or is no longer present.

Diff Detail

Event Timeline

clayborg created this revision.Aug 1 2023, 3:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2023, 3:56 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
clayborg requested review of this revision.Aug 1 2023, 3:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2023, 3:56 PM
clayborg updated this revision to Diff 548497.Aug 9 2023, 12:40 AM

Rebase against latest sources.

ayermolo accepted this revision.Aug 9 2023, 7:53 AM

Does this need a test?

This revision is now accepted and ready to land.Aug 9 2023, 7:53 AM