This is an archive of the discontinued LLVM Phabricator instance.

[flang][openacc] Add lowering support for device_resident clause on OpenACC declare
ClosedPublic

Authored by clementval on Aug 1 2023, 3:06 PM.

Diff Detail

Event Timeline

clementval created this revision.Aug 1 2023, 3:06 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 1 2023, 3:06 PM
clementval requested review of this revision.Aug 1 2023, 3:06 PM
razvanlupusoru requested changes to this revision.Aug 2 2023, 3:07 PM

I think this operation needs an acc.declare_exit + acc.delete. The device_resident variable needs removed from device memory on exit from its implicit data region.

This revision now requires changes to proceed.Aug 2 2023, 3:07 PM

I think this operation needs an acc.declare_exit + acc.delete. The device_resident variable needs removed from device memory on exit from its implicit data region.

Makes sense! I'll update the patch

Add exit operation

razvanlupusoru accepted this revision.Aug 7 2023, 10:06 AM

Looks good to me!

This revision is now accepted and ready to land.Aug 7 2023, 10:06 AM
This revision was landed with ongoing or failed builds.Aug 7 2023, 10:16 AM
This revision was automatically updated to reflect the committed changes.