This is an archive of the discontinued LLVM Phabricator instance.

Differential D156751

[flang] Add missing dependency on tablegen files
ClosedPublic

Authored by clementval on Jul 31 2023, 3:11 PM.

Details

Reviewers
vzakhari
Commits
rG103907bc5fcf: [flang] Add missing dependency on tablegen files
Summary

This issue was raised on https://github.com/llvm/llvm-project/issues/64268.

flang/lib/Optimizer/Transforms/SimplifyIntrinsics.cpp includes
flang/Optimizer/HLFIR/HLFIRDialect.h and might fails if the HLFIR related
tablegen files have not been generated.

Diff Detail

Event Timeline

clementval created this revision.Jul 31 2023, 3:11 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 31 2023, 3:11 PM
Herald added subscribers: sunshaoce, mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Jul 31 2023, 3:11 PM
Herald added a subscriber: jdoerfert. · View Herald TranscriptJul 31 2023, 3:11 PM
vzakhari accepted this revision.Jul 31 2023, 3:21 PM

Thank you! The dependency is just for hlfir::getFortranElementType, so we could have gotten rid of it. Since HLFIR is moving to be the default, let's add a dependency for the time being.

This revision is now accepted and ready to land.Jul 31 2023, 3:21 PM
Harbormaster completed remote builds in B249331: Diff 545829.Jul 31 2023, 3:58 PM
Closed by commit rG103907bc5fcf: [flang] Add missing dependency on tablegen files (authored by clementval). · Explain WhyAug 1 2023, 9:48 AM
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rG103907bc5fcf: [flang] Add missing dependency on tablegen files.

Revision Contents

PathSize
flang/
lib/
Optimizer/
Transforms/
1 line

Diff 546101

flang/lib/Optimizer/Transforms/CMakeLists.txt

Show All 17 Linesadd_flang_library(FIRTransforms
LoopVersioning.cpp LoopVersioning.cpp
OMPEarlyOutlining.cpp OMPEarlyOutlining.cpp
OMPFunctionFiltering.cpp OMPFunctionFiltering.cpp
OMPMarkDeclareTarget.cpp OMPMarkDeclareTarget.cpp
DEPENDS DEPENDS
FIRDialect FIRDialect
FIROptTransformsPassIncGen FIROptTransformsPassIncGen
HLFIROpsIncGen
LINK_LIBS LINK_LIBS
FIRBuilder FIRBuilder
FIRCodeGen FIRCodeGen
FIRDialect FIRDialect
FIRDialectSupport FIRDialectSupport
FIRSupport FIRSupport
HLFIRDialect HLFIRDialect
Show All 9 Lines