This is an archive of the discontinued LLVM Phabricator instance.

[flang][openacc] Add global destructor for acc declare construct
ClosedPublic

Authored by clementval on Jul 26 2023, 11:09 AM.

Details

Summary

Add the acc.global_dtor when lowering the OpenACC declare
construct.

Diff Detail

Event Timeline

clementval created this revision.Jul 26 2023, 11:09 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 26 2023, 11:09 AM
clementval requested review of this revision.Jul 26 2023, 11:09 AM

Add missing data exit operation

razvanlupusoru accepted this revision.Jul 27 2023, 11:53 AM

This change looks good. I see a small error with regards to "structured" but can be resolved in a follow-up change!

flang/lib/Lower/OpenACC.cpp
2321

Structured flag should be false for declare in the acc constructor. Sorry I didn't catch this last review. Structured for declare operations will be true when in same function though!

This revision is now accepted and ready to land.Jul 27 2023, 11:53 AM
clementval added inline comments.Jul 27 2023, 11:55 AM
flang/lib/Lower/OpenACC.cpp
2321

Thanks for catching this!

This revision was landed with ongoing or failed builds.Jul 27 2023, 12:59 PM
This revision was automatically updated to reflect the committed changes.