This is an archive of the discontinued LLVM Phabricator instance.

Differential D156351

clang driver throws error for -mabi=elfv2 or elfv2
ClosedPublic

Authored by long5hot on Jul 26 2023, 10:51 AM.

Details

Reviewers
jhibbits
nemanjai
sfertile
Group Reviewers
Restricted Project
Commits
rG065da3574b4f: clang driver throws error for -mabi=elfv2 or elfv2
Summary

After clang release/16.x there is a regression that -mabi=elfv1
or -mabi=elfv2 are being unused and throws warning. But clang-trunk
throws error for -mabi=elfv2 or elfv1. Intent of this patch to accept
elfv1 or elfv2 for -mabi.

PR : https://github.com/llvm/llvm-project/issues/64122
godBolt : https://godbolt.org/z/asbMY1K37

Diff Detail

Event Timeline

long5hot created this revision.Jul 26 2023, 10:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2023, 10:51 AM
long5hot requested review of this revision.Jul 26 2023, 10:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2023, 10:51 AM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
long5hot added reviewers: jhibbits, nemanjai, sfertile, Restricted Project.Jul 26 2023, 10:53 AM
long5hot edited the summary of this revision. (Show Details)
MaskRay added a comment.Jul 26 2023, 4:18 PM

After clang release/16.x there is a regression that -mabi=elfv1 or -mabi=elfv2 are being unused and throws warning.

Please just give the full clang command line and add a test case under test/Driver. FWIW: clang --target=powerpc64le-linux-gnu -mabi=elfv1 -mabi=elfv2 -c a.c works for me without any warning.

Harbormaster completed remote builds in B248317: Diff 544439.Jul 26 2023, 4:44 PM
long5hot updated this revision to Diff 544674.Jul 27 2023, 3:06 AM

failure is only when we do not give full target triple.
for e.x. --target=ppc64 -mabi=elfv2
or even when OS option is unknown e.g. --target=powerpc64-unknown-gnu

Herald added a subscriber: kbarton. · View Herald TranscriptJul 27 2023, 3:06 AM
Harbormaster completed remote builds in B248486: Diff 544674.Jul 27 2023, 4:11 AM
nemanjai accepted this revision.Jul 27 2023, 11:08 AM

Ah, ok. This makes sense. When we don't know anything about the ABI, it makes sense to rely on -mabi.

This revision is now accepted and ready to land.Jul 27 2023, 11:08 AM
MaskRay added inline comments.Jul 27 2023, 10:50 PM
clang/test/Driver/ppc-abi.c
18

-target has been deprecated since Clang 3.4. Use --target= for new tests:_

This revision was landed with ongoing or failed builds.Jul 29 2023, 3:44 AM
Closed by commit rG065da3574b4f: clang driver throws error for -mabi=elfv2 or elfv2 (authored by long5hot). · Explain Why
This revision was automatically updated to reflect the committed changes.
long5hot added a commit: rG065da3574b4f: clang driver throws error for -mabi=elfv2 or elfv2.
long5hot added inline comments.Jul 29 2023, 3:49 AM
clang/test/Driver/ppc-abi.c
18

Did a small testCase change here, because of this #64194 bug ..

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
6 lines
test/
Driver/
6 lines

Diff 545359

clang/lib/Driver/ToolChains/Clang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,062 Lines • ▼ Show 20 Lines if (V == "ieeelongdouble") {
IEEELongDouble = false; IEEELongDouble = false;
A->claim(); A->claim();
} else if (V == "vec-default") { } else if (V == "vec-default") {
VecExtabi = false; VecExtabi = false;
A->claim(); A->claim();
} else if (V == "vec-extabi") { } else if (V == "vec-extabi") {
VecExtabi = true; VecExtabi = true;
A->claim(); A->claim();
} else if (V == "elfv1") {
ABIName = "elfv1";
A->claim();
} else if (V == "elfv2") {
ABIName = "elfv2";
A->claim();
} else if (V != "altivec") } else if (V != "altivec")
// The ppc64 linux abis are all "altivec" abis by default. Accept and ignore // The ppc64 linux abis are all "altivec" abis by default. Accept and ignore
// the option if given as we don't have backend support for any targets // the option if given as we don't have backend support for any targets
// that don't use the altivec abi. // that don't use the altivec abi.
ABIName = A->getValue(); ABIName = A->getValue();
} }
if (IEEELongDouble) if (IEEELongDouble)
CmdArgs.push_back("-mabi=ieeelongdouble"); CmdArgs.push_back("-mabi=ieeelongdouble");
▲ Show 20 Lines • Show All 6,648 Lines • Show Last 20 Lines

clang/test/Driver/ppc-abi.c

Show All 9 Lines
// RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \ // RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
// RUN: | FileCheck -check-prefix=CHECK-ELFv2 %s // RUN: | FileCheck -check-prefix=CHECK-ELFv2 %s
// RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \ // RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
// RUN: -mabi=elfv1 | FileCheck -check-prefix=CHECK-ELFv1-LE %s // RUN: -mabi=elfv1 | FileCheck -check-prefix=CHECK-ELFv1-LE %s
// RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \ // RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
// RUN: -mabi=elfv2 | FileCheck -check-prefix=CHECK-ELFv2 %s // RUN: -mabi=elfv2 | FileCheck -check-prefix=CHECK-ELFv2 %s
// RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \ // RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
// RUN: -mabi=altivec | FileCheck -check-prefix=CHECK-ELFv2 %s // RUN: -mabi=altivec | FileCheck -check-prefix=CHECK-ELFv2 %s
// RUN: %clang --target=ppc64 -mabi=elfv1 %s -### -o %t.o 2>&1 \
MaskRayUnsubmitted
Not Done
ReplyInline Actions

-target has been deprecated since Clang 3.4. Use --target= for new tests:_

MaskRay: `-target ` has been deprecated since Clang 3.4. Use `--target=` for new tests:_
long5hotAuthorUnsubmitted
Done
ReplyInline Actions

Did a small testCase change here, because of this #64194 bug ..

long5hot: Did a small testCase change here, because of this [[ https://github.com/llvm/llvm…
// RUN: | FileCheck -check-prefix=CHECK-UNKNOWN-ELFv1 %s
// RUN: %clang --target=ppc64 -mabi=elfv2 %s -### -o %t.o 2>&1 \
// RUN: | FileCheck -check-prefix=CHECK-UNKNOWN-ELFv2 %s
// RUN: %clang -target powerpc64-unknown-freebsd11 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv1 %s // RUN: %clang -target powerpc64-unknown-freebsd11 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv1 %s
// RUN: %clang -target powerpc64-unknown-freebsd12 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv1 %s // RUN: %clang -target powerpc64-unknown-freebsd12 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv1 %s
// RUN: %clang -target powerpc64-unknown-freebsd13 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2-BE %s // RUN: %clang -target powerpc64-unknown-freebsd13 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2-BE %s
// RUN: %clang -target powerpc64-unknown-freebsd14 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2-BE %s // RUN: %clang -target powerpc64-unknown-freebsd14 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2-BE %s
// RUN: %clang -target powerpc64-unknown-freebsd %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2-BE %s // RUN: %clang -target powerpc64-unknown-freebsd %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2-BE %s
// RUN: %clang -target powerpc64le-unknown-freebsd13 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2 %s // RUN: %clang -target powerpc64le-unknown-freebsd13 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2 %s
// RUN: %clang -target powerpc64-unknown-openbsd %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2-BE-PIE %s // RUN: %clang -target powerpc64-unknown-openbsd %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2-BE-PIE %s
// RUN: %clang -target powerpc64-linux-musl %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2-BE-PIE %s // RUN: %clang -target powerpc64-linux-musl %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2-BE-PIE %s
// CHECK-ELFv1: "-target-abi" "elfv1" // CHECK-ELFv1: "-target-abi" "elfv1"
// CHECK-ELFv1-LE: "-target-abi" "elfv1" // CHECK-ELFv1-LE: "-target-abi" "elfv1"
// CHECK-ELFv2: "-target-abi" "elfv2" // CHECK-ELFv2: "-target-abi" "elfv2"
// CHECK-ELFv2-BE: "-target-abi" "elfv2" // CHECK-ELFv2-BE: "-target-abi" "elfv2"
// CHECK-ELFv2-BE-PIE: "-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" // CHECK-ELFv2-BE-PIE: "-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie"
// CHECK-ELFv2-BE-PIE: "-target-abi" "elfv2" // CHECK-ELFv2-BE-PIE: "-target-abi" "elfv2"
// CHECK-UNKNOWN-ELFv1: "-target-abi" "elfv1"
// CHECK-UNKNOWN-ELFv2: "-target-abi" "elfv2"
// RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \ // RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
// RUN: | FileCheck -check-prefix=CHECK-ELFv1-PIC %s // RUN: | FileCheck -check-prefix=CHECK-ELFv1-PIC %s
// RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \ // RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
// RUN: -mabi=elfv1 | FileCheck -check-prefix=CHECK-ELFv1-PIC %s // RUN: -mabi=elfv1 | FileCheck -check-prefix=CHECK-ELFv1-PIC %s
// RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \ // RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
// RUN: -mabi=elfv2 | FileCheck -check-prefix=CHECK-ELFv2-PIC %s // RUN: -mabi=elfv2 | FileCheck -check-prefix=CHECK-ELFv2-PIC %s
Show All 30 Lines