Enable record-replay for OpenMP offload kernels. On recording the initialization is performed on device initialization by reading env variables. (This is similar to the way rr used to operate). The primary change takes place in the replay phase with the replay tool explicitly initializing the record-replay functionality.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
I like the change to an explicit initialization rather than a env var based one (for the replay tool).
There are minor style changes we can fix in tree, and one issue with a missing sync. We also need tests.
All that said, I think we should get this into 17.
openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp | ||
---|---|---|
173 | There is some kind of sync missing here. We should not use an async retrieve to begin with, or wait for it. |
There is some kind of sync missing here. We should not use an async retrieve to begin with, or wait for it.