This is an archive of the discontinued LLVM Phabricator instance.

[Driver][XRay][test] Convert more tests to check 'target=...' after 016785d9316d8c5abc5fdf3cdb86479095bbb677
AbandonedPublic

Authored by SixWeining on Jul 24 2023, 1:24 AM.

Diff Detail

Event Timeline

SixWeining created this revision.Jul 24 2023, 1:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2023, 1:24 AM
Herald added a subscriber: dberris. · View Herald Transcript
SixWeining requested review of this revision.Jul 24 2023, 1:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2023, 1:24 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
SixWeining added inline comments.Jul 24 2023, 2:30 AM
clang/test/Driver/XRay/xray-ignore-loops-flags.cpp
5

x86_64-linux is used here, so maybe we can remove the REQUIRES line directly?

MaskRay added inline comments.Jul 24 2023, 8:58 AM
clang/test/Driver/XRay/xray-ignore-loops-flags.cpp
1

I have cleaned up a few test/Driver/XRay tests last month, but these are what I did not touch.

I'll change these to specify a --target= and avoid target-different behaviors.