The name is not really descriptive, renamed the file and improved the
diagnostics.
As a drive-by fixes one macro to generate a diagnostic.
Paths
| Differential D156051
[libc++] Renames nasty_macro test. ClosedPublic Authored by Mordante on Jul 23 2023, 5:06 AM.
Details
Summary The name is not really descriptive, renamed the file and improved the As a drive-by fixes one macro to generate a diagnostic.
Diff Detail
Event TimelineMordante added a child revision: D156052: [libc++][doc] Improves contribution page..Jul 23 2023, 5:09 AM Comment Actions I'm not sure the name is much better. It still doesn't tell me what the test actually tests. Is it that we only use reserved names? Is it to avoid reserved names from other libraries? Maybe something like system_reserved_names would be better? I think that is mostly what we are trying to protect against. Comment Actions
System or other compilers, especially MSVC uses quite a number of "nice" __ugly_names as "attributes". I'm fine with system_reserved_names. Do you have other comments? If not then I'll update this patch. Comment Actions
Nope. LGTM with the updated name. This revision is now accepted and ready to land.Jul 26 2023, 9:24 AM Comment Actions
Thanks! I'll give the CI a test and then land it. Closed by commit rG97d60af0d33b: [libc++] Renames nasty_macro test. (authored by Mordante). · Explain WhyJul 26 2023, 2:18 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 544516 libcxx/test/libcxx/nasty_macros.gen.py
libcxx/test/libcxx/system_reserved_names.gen.py
|