[llvm-debuginfod] Switch to xxh3_64bits

[MaskRay]

Summary

Many sources show that xxh3 is much better than xxh64. This particular
instance may or may not have noticeable difference, but this change
moves us toward removing xxHash64.

This change will invalid cache and I haven't fixed the tests.
I just want to post the patch first to seek for opinions:)

[MaskRay]

fix tests

[jhenderson]

I think the change makes sense, but I don't really know anything about debuginfod, so can't really be confident.

[MaskRay]

@gulfem @mysterymath :)

llvm/lib/Debuginfod/Debuginfod.cpp

 
 #include <atomic>
 #include <thread>
 
 namespace llvm {
 
 using llvm::object::BuildIDRef;
 
-static std::string uniqueKey(llvm::StringRef S) { return utostr(xxHash64(S)); }
+static std::string uniqueKey(llvm::StringRef S) {
+  return utostr(xxh3_64bits(S));
+}
 
 // Returns a binary BuildID as a normalized hex string.
 // Uses lowercase for compatibility with common debuginfod servers.
 static std::string buildIDToString(BuildIDRef ID) {
   return llvm::toHex(ID, /*LowerCase=*/true);
 }
 
 bool canUseDebuginfod() {

llvm/test/tools/llvm-debuginfod-find/cache.test

 RUN: ls %t/cache | FileCheck --check-prefix=BOTH --match-full-lines --implicit-check-not {{.}} %s
 
 # An invalid cache policy has no effect.
 RUN: env DEBUGINFOD_CACHE_POLICY=invalid:prune_interval=0s:cache_size_files=1 \
 RUN:     DEBUGINFOD_CACHE_PATH=%t/cache DEBUGINFOD_URLS=file://%t \
 RUN:     llvm-debuginfod-find --debuginfo 0123456789012346 > /dev/null
 RUN: ls %t/cache | FileCheck --check-prefix=BOTH --match-full-lines --implicit-check-not {{.}} %s
 
-FIRST: llvmcache-6663022027345102449
+FIRST: llvmcache-10846399329613630737
 FIRST: llvmcache.timestamp
 
-SECOND: llvmcache-6762748755046480574
+SECOND: llvmcache-10192351353398627645
 SECOND: llvmcache.timestamp
 
-BOTH: llvmcache-6663022027345102449
-BOTH: llvmcache-6762748755046480574
+BOTH: llvmcache-10192351353398627645
+BOTH: llvmcache-10846399329613630737
 BOTH: llvmcache.timestamp

llvm/test/tools/llvm-objdump/debuginfod.test

 RUN: llvm-objcopy --strip-debug %p/Inputs/embedded-source %t/stripped
 
 # Printing source for the stripped binary should fail.
 RUN: env DEBUGINFOD_CACHE_PATH=%t llvm-objdump -d --source %t/stripped | \
 RUN:   FileCheck %s --check-prefix=NOTFOUND
 
 # Use cp to write the debug binary to an appropriately-named file in the llvm
 # debuginfod cache.
-RUN: cp %p/Inputs/embedded-source %t/llvmcache-7361776989772977641
+RUN: cp %p/Inputs/embedded-source %t/llvmcache-17908201640401622315
 
 # Write a broken "binary" under %t/broken.
 RUN: mkdir %t/broken
-RUN: echo "bad" > %t/broken/llvmcache-7361776989772977641
+RUN: echo "bad" > %t/broken/llvmcache-17908201640401622315
 
 # Write the stripped binary under %t/stripped-cache.
 RUN: mkdir %t/stripped-cache
-RUN: cp %t/stripped %t/stripped-cache/llvmcache-7361776989772977641
+RUN: cp %t/stripped %t/stripped-cache/llvmcache-17908201640401622315
 
 # Write to a debug info directory as well.
 RUN: mkdir -p %t/debug/.build-id/15
 RUN: cp %p/Inputs/embedded-source %t/debug/.build-id/15/12f769114c011387393822af15dd660c080295.debug
 
 # Don't use debuginfod by default without any URLs.
 RUN: env DEBUGINFOD_CACHE_PATH=%t llvm-objdump -d --source %t/stripped | \
 RUN:   FileCheck %s --check-prefix=NOTFOUND

 RUN:   %t/stripped | \
 RUN:   FileCheck %s --check-prefix=FOUND
 
 # Produce a warning if a bad binary is fetched, but do not fail.
 RUN: env DEBUGINFOD_CACHE_PATH=%t/broken llvm-objdump -d --source --debuginfod \
 RUN:   %t/stripped 2> %t.err | \
 RUN:   FileCheck %s --check-prefix=NOTFOUND
 RUN: FileCheck %s --check-prefix=BADBINARYERROR -DPATH=%t --input-file %t.err
-BADBINARYERROR: warning: '[[PATH]]/broken{{[/\\]}}llvmcache-7361776989772977641': The file was not recognized as a valid object file
+BADBINARYERROR: warning: '[[PATH]]/broken{{[/\\]}}llvmcache-17908201640401622315': The file was not recognized as a valid object file
 
 # Use the original binary if the fetched binary has no debug info.
 RUN: env DEBUGINFOD_CACHE_PATH=%t/stripped-cache llvm-objdump -d --source \
 RUN:   --debuginfod %t/stripped 2> %t.err | \
 RUN:   FileCheck %s --check-prefix=NOTFOUND
 RUN: count 0 < %t.err
 
 # Use debuginfod to look up build IDs.

 # Use debuginfod to recover symbols.
 RUN: llvm-strip --strip-sections %t/stripped
 RUN: env DEBUGINFOD_CACHE_PATH=%t llvm-objdump -d --debuginfod \
 RUN:   %t/stripped | \
 RUN:   FileCheck %s --check-prefix=SYMBOLS
 
 # Use debuginfod to recover section headers, but not symbols.
 RUN: mkdir %t/stripped-symbols
-RUN: cp %p/Inputs/embedded-source %t/stripped-symbols/llvmcache-7361776989772977641
-RUN: llvm-strip %t/stripped-symbols/llvmcache-7361776989772977641
+RUN: cp %p/Inputs/embedded-source %t/stripped-symbols/llvmcache-17908201640401622315
+RUN: llvm-strip %t/stripped-symbols/llvmcache-17908201640401622315
 RUN: env DEBUGINFOD_CACHE_PATH=%t/stripped-symbols llvm-objdump -d \
 RUN:   --debuginfod %t/stripped | \
 RUN:   FileCheck %s --check-prefix=SECTIONS
 
 # Don't use debuginfod if neither section headers nor symbols can be recovered.
 RUN: mkdir %t/stripped-sections
 RUN: echo "" | llvm-mc -filetype=obj -triple x86_64 > \
-RUN:   %t/stripped-sections/llvmcache-7361776989772977641
-RUN: llvm-strip --strip-sections %t/stripped-sections/llvmcache-7361776989772977641
+RUN:   %t/stripped-sections/llvmcache-17908201640401622315
+RUN: llvm-strip --strip-sections %t/stripped-sections/llvmcache-17908201640401622315
 RUN: env DEBUGINFOD_CACHE_PATH=%t/stripped-sections llvm-objdump -d \
 RUN:   --debuginfod %t/stripped | \
 RUN:   FileCheck %s --check-prefix=NOSECTIONS
 
 NOTFOUND-NOT: int main(int argc, char *argv[]) {
 FOUND: int main(int argc, char *argv[]) {
 
 SYMBOLS: <main>:
 SECTIONS: <.text>:
 NOSECTIONS: <PT_LOAD#{{[0-9]+}}>:

llvm/test/tools/llvm-symbolizer/debuginfod.test

 RUN:   --obj=%t/addr.exe 0x40054d | FileCheck %s --check-prefix=NOTFOUND
 NOTFOUND: 0x40054d
 NOTFOUND-NEXT: main
 NOTFOUND-NEXT: ??:0:0
 
 # Use llvm-objcopy to write the debuginfo of the addr.exe binary to an
 # appropriately-named file in the llvm debuginfod cache. The filename is
 # determined by the debuginfod client's caching scheme, so it is manually
-# specified here as llvmcache-98...19
+# specified here as llvmcache-\d+
 RUN: llvm-objcopy --keep-section=.debug_info %p/Inputs/addr.exe \
-RUN:   %t/llvmcache-9800707741016212219
+RUN:   %t/llvmcache-1165050469834211050
 
 # The symbolizer should call the debuginfod client library, which finds the
 # debuginfo placed in the cache, enabling symbolization of the address.
 RUN: env DEBUGINFOD_CACHE_PATH=%t llvm-symbolizer \
 RUN:   --obj=%t/addr.exe 0x40054d --debuginfod | \
 RUN:   FileCheck %s --check-prefix=FOUND
 FOUND: {{[/\]+}}tmp{{[/\]+}}x.c:14:0