This is an archive of the discontinued LLVM Phabricator instance.

[libc++][hardening][NFC] Rework the Lit feature for detecting the hardening mode.
ClosedPublic

Authored by var-const on Jul 20 2023, 6:06 PM.

Details

Summary

Make it a multichoice string to closer mirror the CMake variable. This
allows writing UNSUPPORTED: libcpp-hardening-mode=unchecked rather
than UNSUPPORTED: !libcpp-has-hardened-mode && !libcpp-has-debug-mode.

Diff Detail

Event Timeline

var-const created this revision.Jul 20 2023, 6:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2023, 6:06 PM
var-const requested review of this revision.Jul 20 2023, 6:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2023, 6:06 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jul 21 2023, 9:38 AM
ldionne added a subscriber: ldionne.

I like this!

This revision is now accepted and ready to land.Jul 21 2023, 9:38 AM

I'll hold off merging this to avoid creating conflicts with other patches aiming for the upcoming release (particularly https://reviews.llvm.org/D154367).

Since we have branched is there a reason to keep this patch open longer or can we land it?

This revision was landed with ongoing or failed builds.Aug 4 2023, 12:22 AM
This revision was automatically updated to reflect the committed changes.