This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][Utils] Pass cmp-rev to nfc-check-setup
ClosedPublic

Authored by Amir on Jul 18 2023, 3:43 PM.

Details

Reviewers
rafauler
maksfb
Group Reviewers
Restricted Project
Commits
rG3837e3e6cecb: [BOLT][Utils] Pass cmp-rev to nfc-check-setup
Summary

Pass the revision to checkout to (cmp-rev) as nfc-check-setup option.
Simpifies the comparison against arbitrary commit, not just the previous one.

Diff Detail

Event Timeline

Amir created this revision.Jul 18 2023, 3:43 PM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Amir requested review of this revision.Jul 18 2023, 3:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 3:43 PM
rafauler accepted this revision.Jul 18 2023, 6:00 PM
This revision is now accepted and ready to land.Jul 18 2023, 6:00 PM
This revision was automatically updated to reflect the committed changes.