This is an archive of the discontinued LLVM Phabricator instance.

Differential D155644

[test] Make fuzzer/value-profile-div.test x86 specific
ClosedPublic

Authored by MaskRay on Jul 18 2023, 2:26 PM.

Details

Reviewers
rsundahl
vitalybuka
Ami-zhang
Commits
rG307e19784a7c: [test] Make fuzzer/value-profile-div.test x86 specific
Summary

The test requires that an integer division by zero causes a trap, leading to a
signal like SIGFPE. This is the case on x86. On many other architectures, such
as Arm (unless software division is used and __aeabi_idiv0 is patched),
Power, RISC-V, LoongArch, there is no trap. Therefore, it's more appropriate to
invert the condition to run the test.

Diff Detail

Event Timeline

MaskRay created this revision.Jul 18 2023, 2:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 2:26 PM
Herald added subscribers: Enna1, luismarques, pengfei and 5 others. · View Herald Transcript
MaskRay requested review of this revision.Jul 18 2023, 2:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 2:26 PM
Herald added subscribers: Restricted Project, wangpc. · View Herald Transcript
MaskRay mentioned this in D155591: [libFuzzer][test] Add %if target={{loongarch64.*}} after D128572.Jul 18 2023, 2:26 PM
Harbormaster completed remote builds in B246354: Diff 541736.Jul 18 2023, 2:41 PM
Ami-zhang accepted this revision.Jul 18 2023, 7:04 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 18 2023, 7:04 PM
Closed by commit rG307e19784a7c: [test] Make fuzzer/value-profile-div.test x86 specific (authored by MaskRay). · Explain WhyJul 18 2023, 10:11 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rG307e19784a7c: [test] Make fuzzer/value-profile-div.test x86 specific.

Revision Contents

PathSize
compiler-rt/
test/
fuzzer/
3 lines

Diff 541736

compiler-rt/test/fuzzer/value-profile-div.test

UNSUPPORTED: ios REQUIRES: target={{(i.86|x86_64)-.*}}
UNSUPPORTED: target={{(arm|aarch64).*}}
CHECK: AddressSanitizer: {{FPE|int-divide-by-zero}} CHECK: AddressSanitizer: {{FPE|int-divide-by-zero}}
RUN: %cpp_compiler %S/DivTest.cpp -fsanitize-coverage=trace-div -o %t-DivTest RUN: %cpp_compiler %S/DivTest.cpp -fsanitize-coverage=trace-div -o %t-DivTest
RUN: not %run %t-DivTest -seed=1 -use_value_profile=1 -runs=10000000 2>&1 | FileCheck %s RUN: not %run %t-DivTest -seed=1 -use_value_profile=1 -runs=10000000 2>&1 | FileCheck %s