This is an archive of the discontinued LLVM Phabricator instance.

[ODS] Quick fix
ClosedPublic

Authored by amandatang on Jul 18 2023, 1:35 PM.

Details

Summary

Quick fix for a failing test in https://reviews.llvm.org/rG5267ed05bc4612e91409d63b4dbc4e01751acb75.

When properties is empty, the getProperties method in the OpAdaptor class returns an empty struct as opposed to a null pointer. This caused the null check on the properties of ConstShapeOp to fail. The fix involves performing the null check on the shape value within the Properties struct.

Diff Detail

Event Timeline

amandatang created this revision.Jul 18 2023, 1:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 1:35 PM
amandatang requested review of this revision.Jul 18 2023, 1:35 PM
amandatang retitled this revision from Quick fix to [ODS] Quick fix.Jul 18 2023, 1:37 PM
amandatang edited the summary of this revision. (Show Details)
jpienaar accepted this revision.Jul 18 2023, 1:42 PM

Please update the description to make it clear what is being fixed

This revision is now accepted and ready to land.Jul 18 2023, 1:42 PM
This revision was landed with ongoing or failed builds.Jul 18 2023, 1:44 PM
Closed by commit rG729ffb5cdf3e: [ODS] Quick fix (authored by amandatang). · Explain Why
This revision was automatically updated to reflect the committed changes.
amandatang edited the summary of this revision. (Show Details)Jul 18 2023, 1:53 PM
amandatang edited the summary of this revision. (Show Details)

Can you add a non-python test to exercise this please?