This is an archive of the discontinued LLVM Phabricator instance.

Differential D155512

[libc++][PSTL] Add vectorization annotations when clang is used
ClosedPublic

Authored by philnik on Jul 17 2023, 1:14 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG15941dd6296c: [libc++][PSTL] Add vectorization annotations when clang is used

Diff Detail

Unit TestsFailed

TimeTest
450 mslibcxx CI - Apple back-deployment macosx11.0 arm64 > apple-libc++-backdeployment-cfg-in.libcxx/strings/basic_string/string_capacity::PR53170.pass.cpp
1,110 mslibcxx CI - Apple back-deployment macosx11.0 arm64 > apple-libc++-backdeployment-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_mods::refresh.pass.cpp
1,060 mslibcxx CI - Apple back-deployment macosx11.0 arm64 > apple-libc++-backdeployment-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_obs::file_size.pass.cpp
1,130 mslibcxx CI - Apple back-deployment macosx11.0 arm64 > apple-libc++-backdeployment-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_obs::hard_link_count.pass.cpp
1,010 mslibcxx CI - Apple back-deployment macosx11.0 arm64 > apple-libc++-backdeployment-cfg-in.std/input_output/filesystems/class_directory_entry/directory_entry_obs::last_write_time.pass.cpp
View Full Test Results (96 Failed)

Event Timeline

philnik created this revision.Jul 17 2023, 1:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2023, 1:14 PM
philnik requested review of this revision.Jul 17 2023, 1:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2023, 1:14 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, wangpc. · View Herald Transcript
ldionne accepted this revision.Jul 17 2023, 1:47 PM
This revision is now accepted and ready to land.Jul 17 2023, 1:47 PM
Harbormaster completed remote builds in B245982: Diff 541205.Jul 17 2023, 6:26 PM
philnik updated this revision to Diff 545227.Jul 28 2023, 11:03 AM

Try to fix CI

Harbormaster completed remote builds in B248894: Diff 545227.Jul 28 2023, 3:55 PM
philnik added a comment.Jul 31 2023, 6:51 PM

The CI failures look unrelated, so I'm landing this.

This revision was landed with ongoing or failed builds.Jul 31 2023, 6:52 PM
Closed by commit rG15941dd6296c: [libc++][PSTL] Add vectorization annotations when clang is used (authored by philnik). · Explain Why
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG15941dd6296c: [libc++][PSTL] Add vectorization annotations when clang is used.

Revision Contents

PathSize
libcxx/
include/
10 lines

Diff 545227

libcxx/include/__config

Show First 20 Lines • Show All 1,403 Lines • ▼ Show 20 Lines
// OP - type of the callable object with the reduction operation // OP - type of the callable object with the reduction operation
// omp_in - refers to the local partial result // omp_in - refers to the local partial result
// omp_out - refers to the final value of the combiner operator // omp_out - refers to the final value of the combiner operator
// omp_priv - refers to the private copy of the initial value // omp_priv - refers to the private copy of the initial value
// omp_orig - refers to the original variable to be reduced // omp_orig - refers to the original variable to be reduced
# define _PSTL_PRAGMA_DECLARE_REDUCTION(NAME, OP) \ # define _PSTL_PRAGMA_DECLARE_REDUCTION(NAME, OP) \
_PSTL_PRAGMA(omp declare reduction(NAME:OP : omp_out(omp_in)) initializer(omp_priv = omp_orig)) _PSTL_PRAGMA(omp declare reduction(NAME:OP : omp_out(omp_in)) initializer(omp_priv = omp_orig))
# elif defined(_LIBCPP_COMPILER_CLANG_BASED)
# define _PSTL_PRAGMA_SIMD _Pragma("clang loop vectorize(enable) interleave(enable)")
# define _PSTL_PRAGMA_DECLARE_SIMD
# define _PSTL_PRAGMA_SIMD_REDUCTION(PRM) _Pragma("clang loop vectorize(enable) interleave(enable)")
# define _PSTL_PRAGMA_SIMD_SCAN(PRM) _Pragma("clang loop vectorize(enable) interleave(enable)")
# define _PSTL_PRAGMA_SIMD_INCLUSIVE_SCAN(PRM)
# define _PSTL_PRAGMA_SIMD_EXCLUSIVE_SCAN(PRM)
# define _PSTL_PRAGMA_DECLARE_REDUCTION(NAME, OP)
# else // (defined(_OPENMP) && _OPENMP >= 201307) # else // (defined(_OPENMP) && _OPENMP >= 201307)
# define _PSTL_PRAGMA_SIMD # define _PSTL_PRAGMA_SIMD
# define _PSTL_PRAGMA_DECLARE_SIMD # define _PSTL_PRAGMA_DECLARE_SIMD
# define _PSTL_PRAGMA_SIMD_REDUCTION(PRM) # define _PSTL_PRAGMA_SIMD_REDUCTION(PRM)
# define _PSTL_PRAGMA_SIMD_SCAN(PRM) # define _PSTL_PRAGMA_SIMD_SCAN(PRM)
# define _PSTL_PRAGMA_SIMD_INCLUSIVE_SCAN(PRM) # define _PSTL_PRAGMA_SIMD_INCLUSIVE_SCAN(PRM)
# define _PSTL_PRAGMA_SIMD_EXCLUSIVE_SCAN(PRM) # define _PSTL_PRAGMA_SIMD_EXCLUSIVE_SCAN(PRM)
Show All 9 Lines